-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeletonified client #61
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [black](https://github.com/psf/black) from 22.6.0 to 22.8.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.6.0...22.8.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
There are now developer and user guides. The version switcher is native to the theme so added a script to generate it.
This saves another runner starting up just for this
Fixing a bug that occurs when releasing. (This is already fixed in the skeleton-cli project but failed to get copied to skeleton).
Co-authored-by: Tom C (DLS) <[email protected]>
Pin pydata-sphinx-theme to allow the build to complete pydata/pydata-sphinx-theme#987
Use the official Python Packaging Authority (PyPA) Action to publish to PyPI
Bumps [black](https://github.com/psf/black) from 22.8.0 to 22.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](psf/black@22.8.0...22.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Translate punctuation and unicode in branch names to _
- Environment variable no longer needs to be set - All commands run with tox-direct by default - All environment variables passed through
- Moved wheel and sdist creation to the dist job - Rely on the test matrix to run tests - Simplified container build to make minimal for build and runtime and use wheel from 'dist': only publish to GHCR for tagged builds - Create separate requirements-*.txt for each of the test matrix - Fix actions-gh-pages version and don't run it for dependabot - Move Dockerfile to .devcontainer and use as context to improve build times - Other minor improvements and simplifications
…ipfile options into pyproject.toml
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
==========================================
+ Coverage 96.34% 96.35% +0.01%
==========================================
Files 12 12
Lines 1175 1180 +5
==========================================
+ Hits 1132 1137 +5
Misses 43 43
☔ View full report in Codecov by Sentry. |
93cefda
to
5a3ce72
Compare
d059bc0
to
87bbb3d
Compare
15d32d8
to
d34b755
Compare
d34b755
to
309f095
Compare
5478b08
to
7e74ba6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of bits to clean up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Classifier needs fixing
5bf1af9
to
ddb7b01
Compare
It's not strictly required in this PR, but I'll mention it here: There needs to be a redirect set up from the old documentation site (https://pandablocks-client.readthedocs.io/en/stable/index.html), to the new GitHub pages one. This might be doable using this project, but that was designed to work with DiamondLightSource organization so may require some tweaking. Or doing it manually. |
I can make a ticket for this. What's the purpose of this though - is it just to ensure links to the docs already in place in other projects will redirect to the new link? |
Exactly that - we want any links that may be left lying around in odd places, e.g. third party documentation, or wikis, to always go to the right place. |
Created a ticket #62 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Closes #57
Skeletonified pandablocks, moved docs to the new structure.
The new docs publishing is working, they can be viewed here.