Made conversion on enum fields to List[str] optional #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 12 12
Lines 1170 1170
=======================================
Hits 1127 1127
Misses 43 43
☔ View full report in Codecov by Sentry. |
AlexanderWells-diamond
requested changes
Oct 10, 2023
AlexanderWells-diamond
requested changes
Oct 10, 2023
evalott100
force-pushed
the
make_conversion_to_string_enums_optional
branch
from
167fa62
to
738af76
Compare
evalott100
force-pushed
the
make_conversion_to_string_enums_optional
branch
from
738af76
to
6ccaa8f
Compare
AlexanderWells-diamond
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default pandablocks-ioc will refer to enum values by their integer indices, with values being stored in a
numpy.uint8.Because of this, we make conversion to a
List[str]of enum values optional in pandablocks client.