Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SAMPLES -> GATE_DURATION and add NOMINAL_CLOCK #152

Closed
coretl opened this issue Sep 19, 2023 · 2 comments
Closed

Rename SAMPLES -> GATE_DURATION and add NOMINAL_CLOCK #152

coretl opened this issue Sep 19, 2023 · 2 comments

Comments

@coretl
Copy link
Contributor

coretl commented Sep 19, 2023

As per PandABlocks/PandABlocks-server#8 (comment)

NOMINAL_CLOCK should be hardcoded to 125e9. #150 will put actual numbers in it
@Araneidae
Copy link
Contributor

You actually mean 125_000_000 of course (125e6 as an integer).

Araneidae added a commit that referenced this issue Sep 20, 2023
@Araneidae
Rename SAMPLES to GATE_DURATION
26ffcfb 
This addresses part of issues PandABlocks-server#8 and #152
@Araneidae Araneidae mentioned this issue Sep 20, 2023
Merged
@Araneidae
Copy link
Contributor

This is addressed by commits 26ffcfb and eecb30e

shihab-dls pushed a commit that referenced this issue May 17, 2024
@Araneidae
Rename SAMPLES to GATE_DURATION
81542f2 
This addresses part of issues PandABlocks-server#8 and #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Araneidae @coretl