Feature/arbitrary fields #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tidy up error reporting when PandA is disconnected See merge request controls/support/adpandablocks!1
…bug with NDAttributeFile not working)
… to control a TTLOUT
thomascobb
suggested changes
Jan 2, 2020
| if (it != posBusLookup.end()) { | ||
| std::map<std::string, int*>::iterator it2 = it->second.find(fieldName); | ||
| if (it2 != it->second.end()) { | ||
| for (int ind = 0; ind < NCUSTOM; ind++) { |
There was a problem hiding this comment.
I'm worried this will affect performance as this code is run at 10Hz for every param change.
Also, these are not necessarily PosBus params, can't the custom code deal with any types of params?
Instead of doing this inner loop, can we add a customParam map that contains precisely what we need to extract in the loop?
added 7 commits
January 6, 2020 10:36
…s loop to improve performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to set arbitrary PandA fields via EPICS + a db template to control a TTLOUT