refactor: bootstrap and vmseries #371

FoSix · 2023-12-19T09:46:43Z

No description provided.

acelebanski

Left a few comments, mainly regarding vmseries module.

modules/vmseries/variables.tf

modules/vmseries/main.tf

examples/vmseries/main.tf

acelebanski

Some more comments on variables validation.

modules/vmseries/variables.tf

sebastianczech

As always great job 👍

modules/bootstrap/main.tf

modules/bootstrap/versions.tf

modules/vmseries/versions.tf

modules/vmseries/variables.tf

modules/vmseries/main.tf

modules/bootstrap/main.tf

…ootstrap-refactor

FoSix · 2024-01-12T13:02:08Z

/idempotence paths="examples/common_vmseries examples/dedicated_vmseries" tf_version="1.5. 1.6"

Testing job ID: 7502521268
Job result: SUCCESS

acelebanski

Left comments on the modules code.

modules/vmseries/variables.tf

modules/vmseries/main.tf

modules/bootstrap/variables.tf

examples/common_vmseries/example.tfvars

examples/standalone_vmseries/variables.tf

alperenkose · 2024-01-16T10:19:34Z

modules/bootstrap/main.tf

  tags                     = var.tags

-  queue_properties {


We don't need these settings anymore? Wouldn't storage_acl be useful?

I see, acl has been moved to azurerm_storage_account_network_rules.
Do we need the retention settings?

modules/bootstrap/variables.tf

modules/bootstrap/.header.md

modules/loadbalancer/variables.tf

modules/vmseries/main.tf

modules/vmseries/variables.tf

examples/virtual_network_gateway/main.tf

acelebanski

I'm fine with it now, let's fix the examples after we migrate to the new repo.

alperenkose

👍🏻

FoSix added 8 commits December 5, 2023 09:37

Merge branch '307-refactor-modules' into 327-bootstrap-refactor

50eb57c

bootstrap refactored + sample example code

cdc8745

update module outputs and documentation

b5141ab

Merge branch '307-refactor-modules' into 327-bootstrap-refactor

d83f8f0

vmseries module + simple example, no bootstrap tests yet

8928e19

working sample vmseries example with partial bootstrap

7932a15

working sample with bootstrap

5e326a5

enable both ssh and password auth

826d263

acelebanski reviewed Dec 20, 2023

View reviewed changes

modules/vmseries/variables.tf Outdated Show resolved Hide resolved

modules/vmseries/variables.tf Outdated Show resolved Hide resolved

Merge branch '307-refactor-modules' into 327-bootstrap-refactor

eee7a09

sebastianczech reviewed Dec 21, 2023

View reviewed changes

acelebanski added the refactor label Dec 21, 2023

FoSix added 4 commits January 5, 2024 09:00

add disk encryption

ff2b20e

Merge remote-tracking branch 'origin/307-refactor-modules' into 327-b…

5dc60ff

…ootstrap-refactor

added changes from comments

adc202d

common example adjusted and working - no documentation yet

59344c7

FoSix force-pushed the 327-bootstrap-refactor branch from 2a7140b to e6ba3e8 Compare January 11, 2024 10:38

common refactor with documentation, not following reference arch yet

245d0a1

FoSix force-pushed the 327-bootstrap-refactor branch from e6ba3e8 to 245d0a1 Compare January 11, 2024 10:57

FoSix added 2 commits January 11, 2024 12:00

Merge branch '307-refactor-modules' into 327-bootstrap-refactor

19117c9

vmseries + bootstrap examples refactored

1c019e0

FoSix marked this pull request as ready for review January 12, 2024 12:59

FoSix requested review from acelebanski and sebastianczech January 12, 2024 12:59

acelebanski reviewed Jan 12, 2024

View reviewed changes

examples/common_vmseries/example.tfvars Show resolved Hide resolved

acelebanski reviewed Jan 12, 2024

View reviewed changes

examples/standalone_vmseries/variables.tf Outdated Show resolved Hide resolved

acelebanski reviewed Jan 12, 2024

View reviewed changes

examples/standalone_vmseries/variables.tf Outdated Show resolved Hide resolved

acelebanski reviewed Jan 12, 2024

View reviewed changes

examples/standalone_vmseries/variables.tf Outdated Show resolved Hide resolved

alperenkose suggested changes Jan 16, 2024

View reviewed changes

changes from comments

8956833

FoSix force-pushed the 327-bootstrap-refactor branch from 3b8db91 to 8956833 Compare January 22, 2024 12:16

FoSix requested review from acelebanski and alperenkose January 22, 2024 12:16

acelebanski approved these changes Jan 22, 2024

View reviewed changes

alperenkose approved these changes Jan 22, 2024

View reviewed changes

FoSix merged commit ad1c4d7 into 307-refactor-modules Jan 22, 2024

FoSix deleted the 327-bootstrap-refactor branch January 22, 2024 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: bootstrap and vmseries #371

refactor: bootstrap and vmseries #371

FoSix commented Dec 19, 2023

acelebanski left a comment

acelebanski left a comment

sebastianczech left a comment

FoSix commented Jan 12, 2024 •

edited by github-actions bot

Loading

acelebanski left a comment

alperenkose Jan 16, 2024

alperenkose Jan 16, 2024

acelebanski left a comment

alperenkose left a comment

refactor: bootstrap and vmseries #371

refactor: bootstrap and vmseries #371

Conversation

FoSix commented Dec 19, 2023

acelebanski left a comment

Choose a reason for hiding this comment

acelebanski left a comment

Choose a reason for hiding this comment

sebastianczech left a comment

Choose a reason for hiding this comment

FoSix commented Jan 12, 2024 • edited by github-actions bot Loading

acelebanski left a comment

Choose a reason for hiding this comment

alperenkose Jan 16, 2024

Choose a reason for hiding this comment

alperenkose Jan 16, 2024

Choose a reason for hiding this comment

acelebanski left a comment

Choose a reason for hiding this comment

alperenkose left a comment

Choose a reason for hiding this comment

FoSix commented Jan 12, 2024 •

edited by github-actions bot

Loading