feat(codegen): Render intermediate XML structures to support empty variant lists #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklimonda-cl
force-pushed
the
feat-codegen-sdk-rework
branch
from
f9f3e2a to
9529b68
Compare
kklimonda-cl
force-pushed
the
feat-codegen-variant-lists
branch
from
dc2f6b5 to
0675e57
Compare
kklimonda-cl
force-pushed
the
feat-codegen-sdk-rework
branch
from
9529b68 to
f3de2b3
Compare
kklimonda-cl
force-pushed
the
feat-codegen-variant-lists
branch
from
0675e57 to
9529b68
Compare
kklimonda-cl
force-pushed
the
feat-codegen-sdk-rework
branch
from
f3de2b3 to
ae3ccb7
Compare
kklimonda-cl
force-pushed
the
feat-codegen-variant-lists
branch
from
9529b68 to
6949d78
Compare
kklimonda-cl
changed the title
migara
approved these changes
May 20, 2025
kklimonda-cl
force-pushed
the
feat-codegen-sdk-rework
branch
from
ae3ccb7 to
2256914
Compare
kklimonda-cl
force-pushed
the
feat-codegen-variant-lists
branch
from
6949d78 to
501201a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support list variants XML structures must be adjusted to make sure that
variant list node is not generated if no list elements are present. This cannot be
achieved with
xml:"list>entry,omitempty"due to golang/go#7233 andrequire us to generate an intermediate XML structure instead.