Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to python3 #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aaronkaplan
Copy link

@aaronkaplan aaronkaplan commented Feb 22, 2023

Description

did a few trivial changes (+ linked to docu) on how to upgrade the code base to python3.

Motivation and Context

python2 is pretty much dead.

How Has This Been Tested?

tested against a PDF , extracted the IoCs. Seems to work. The changes were trivial enough to not add extra unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly. (--> added a CHANGELOG file)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate. -> n/a
  • All new and existing tests passed. --> n/a

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@aaronkaplan
Copy link
Author

@pan-bot please merge at least one of these PRs. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant