Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated node packages #699

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

Doron-Bargo
Copy link
Contributor

@Doron-Bargo Doron-Bargo commented Jan 17, 2024

Description

Today the code generator for node generate code example with requests and/or unirest

Motivation and Context

request package was deprecated back in 2020
unirest last commit was 6 years ago

How Has This Been Tested?

I swizzled ApiExplorer/CodeSnippets as mention in issue #686 and tested it on our Logz.io public api docs site

Screenshots (if appropriate)

Before:
Screenshot 2024-01-17 at 20 01 01

After:
Screenshot 2024-01-17 at 19 54 23

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link

Visit the preview URL for this PR (updated for commit 40d4ab3):

https://docusaurus-openapi-36b86--pr699-73jgcuo8.web.app

(expires Fri, 16 Feb 2024 20:06:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@sserrata sserrata merged commit ef8ab66 into PaloAltoNetworks:main Jan 17, 2024
14 checks passed
sserrata pushed a commit that referenced this pull request Jan 18, 2024
* Remove deprecated node packages

* Update languages.json

* Update languagetabs.md
sserrata added a commit that referenced this pull request Jan 18, 2024
* Prepare release v3.0.0-beta.5

* Add markdown support to example summary (#690)

* Add Markdown import to api doc generator

* support markdown rendering for example summary

* add markdown component

* install missing eslint package

* fix import order

* update lock file

* Remove deprecated node packages (#699)

* Remove deprecated node packages

* Update languages.json

* Update languagetabs.md

* Prepare release v3.0.0-beta.5

---------

Co-authored-by: Doron Bargo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants