fix: Make plugin registration be compatible with Qt Creator 16 #80
Conversation
|
But QtCreator16 hasn't been released yet? |
Yes, I'm building from source. However, there has been rc1 already. |
|
I don't expect that this PR should be merged now, but it will hopefully save some time once the project needs to support Qt Creator 16. It's also a pity that it's not possible to support multiple Qt Creator versions as Qt Creator version is not exposed anywhere in C++ defines. |
|
Yeah, thank you, just unexpected :) Early I have checked changes in QtC16 and as far as I understand the idea of Qt, the registration setting should be moved to the initialize() function inside the ExtensionSystem::IPlugin inheritor. In our case qodeassist.cpp:initialize(). Could you change that? |
|
Sorry, what an embarrasment :( Yes, will implement this correctly. |
p12tic
force-pushed
the
qtcreator-16-registration
branch
from
4ca52a9 to
02aec53
Compare
|
Fixed. Note that PR is rebased on top of #81 because it includes settings constants more widely. |
p12tic
force-pushed
the
qtcreator-16-registration
branch
from
02aec53 to
4cfad04
Compare
|
Rebased after #81 has been merged. |
p12tic
force-pushed
the
qtcreator-16-registration
branch
from
4cfad04 to
1d656aa
Compare
|
Rebased on top of #87, so that this PR can be build with older Qt Creator. |
|
Marked as draft until #87 is merged. |
p12tic
force-pushed
the
qtcreator-16-registration
branch
2 times, most recently
from
1c4679d to
707e731
Compare
This introduces changes needed after the following commit in Qt Creator: qt-creator/qt-creator@ba5e4b7 Core: Provide settings categories centrally
p12tic
force-pushed
the
qtcreator-16-registration
branch
from
707e731 to
cad224e
Compare
|
@Palm1r this one can also be merged now. |
This introduces changes needed after the following commit in Qt Creator:
qt-creator/qt-creator@ba5e4b7 Core: Provide settings categories centrally