feat: Re-add support for Qt Creator 15.0.1 #130
Conversation
p12tic
force-pushed
the
qtcreator-16
branch
2 times, most recently
from
165dfa2 to
827171a
Compare
.github/workflows/build_cmake.yml
Outdated
| @@ -13,8 +13,6 @@ on: | |||
| env: | |||
| PLUGIN_NAME: QodeAssist | |||
| QT_VERSION: 6.8.1 | |||
| @@ -47,6 +45,15 @@ jobs: | |||
| platform: mac_x64, | |||
| cc: "clang", cxx: "clang++" | |||
| } | |||
| qt_creator: | |||
| - { | |||
| version: "15.0.1", | |||
There was a problem hiding this comment.
I am not sure about support old version, maybe are leave only current for now and in future add new like beta?
There was a problem hiding this comment.
Why not support older version as well? In our codebase the difference is 10 lines, it's not likely to raise any issues.
It's problematic to force users to upgrade to newest versions of Qt Creator because other third-party extensions may not upgrade as quickly. Also, new Qt Creator versions may contain bugs that break workflows and thus aren't usable. I've been burned by these multiple times. Both of these are barriers to use QodeAssist.
I would say that it makes sense to support all releases, especially since this PR has already done the work. If we actually see maintenance overhead, such as bugs that are specific to single version, then it makes sense to re-evaluate supporting fewer versions.
There was a problem hiding this comment.
In that case, we probably need to take the Qt version as part of it.
There was a problem hiding this comment.
I checked, yes, idea is good but it ieads more changes, for artifacts name, for check and download new version of plugin and plugins.json(indeed I don't know reason of this file like a collect data of plugins) and for usual PR we don't need to check all versions of QtC, only current I think. So lets do it later by another PR and just update now to new QtC version, because we don't have new features for now
There was a problem hiding this comment.
for usual PR we don't need to check all versions of QtC, only current I think.
I think this doesn't matter because each build uses very little resources. It finishes in only couple of minutes.
There was a problem hiding this comment.
Agreed with the rest.
There was a problem hiding this comment.
for check and download new version of plugin
This one already works.
There was a problem hiding this comment.
Not exactly, if we add new multiply versions, which version will be download, plus Qt version, QtCreator 15 based on 6.8.1
p12tic
changed the title
Qt Creator 16.0.0 will be released in days.