Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Decouple prompt template manager from their users #115

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

p12tic
Copy link
Contributor

@p12tic p12tic commented Mar 8, 2025

This makes it possible to test the user classes

@Palm1r
Copy link
Owner

Palm1r commented Mar 8, 2025

let's create a branch for refactoring providers for short time? I'll merge the llama and release 0.5.1 today-tomorrow and will merge refactoring after

@p12tic
Copy link
Contributor Author

p12tic commented Mar 8, 2025

I think it's easier for me to just wait for a bit. If after main is updated there are any merge conflicts or logical merge conflicts where things no longer build, it's less time consuming to resolve these when my changes are not merged anywhere yet.

This makes it possible to test the user classes
@p12tic p12tic force-pushed the decouple-prompt-template-manager branch from 771a393 to c24de4e Compare March 10, 2025 01:08
@Palm1r Palm1r merged commit 98e1047 into Palm1r:main Mar 10, 2025
6 checks passed
@p12tic p12tic deleted the decouple-prompt-template-manager branch March 10, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants