-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App localization test was created for increasing coverage and reliability #1619
App localization test was created for increasing coverage and reliability #1619
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1619 +/- ##
===========================================
+ Coverage 80.61% 80.62% +0.01%
===========================================
Files 144 144
Lines 7272 7272
===========================================
+ Hits 5862 5863 +1
+ Misses 1410 1409 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Kushalrock Please refer to the PR_GUIDELINES.md document in the root folder of the repo. It tells you how to automatically close your issue when the PR is merged. |
Thank you @Cioppolo14. I have already linked the pull request to the issue such that if PR merges issue will get closed. Anything else that I need to add? |
@Kushalrock My apologies, I misunderstood something. I will assign reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kushalrock I think we should also have test written for the usecase where initial language was x(supported language) which later on was switched to y(supported language)
@CyberWake I have done what you asked you can go ahead and check. Thank you for your review. I have uploaded image for reference it also checks whether or not the thing works after locale change |
@CyberWake any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to me
We have a new check in place. All Talawa mobile app methods, classes and functions need to have suitable comments. Please refer to this issue as reference for what is now required. The aim is to help us improve the quality of our automated documentation on docs.talawa.io. To fix this issue:
We have also tried to make the documentation step automatically update your IDE with a custom Linter. If you have any comments, please contact @literalEval who worked on this code. |
@Kushalrock please look for the code coverage why it went low by 0.05%. Resolving so would allow us to proceed to reviewing and merge upon success. |
@CyberWake I will look into that also what is this linting issue that I got commented by Peter. Do I have to do anything about that. Also I have not made any deletion so how can I reduce the code coverage? |
@CyberWake Merged the branch with latest pull now. Can you please check and approve. |
@Kushalrock please add |
@literalEval Done. |
@Kushalrock and remove the extra |
@literalEval Done again 😅🤣 |
:) Thanks. |
@literalEval Can something be developed that will help developers with documentation like some kind of VS Code plugin which can make use of VS code Quick Fix to complete documentation errors or atleast provide a template. |
@Kushalrock that's exactly what we have done with |
@literalEval Thanks I just skimmed through linting section. Shouldn't have done that😅 |
No worries. I have also written a proper documentation for our custom lint system and its merge is pending in |
What kind of change does this PR introduce?
A new test to check app localization utils was introduced
Issue Number
Closes #1530
Have you read the [contributing guide]?
Yes
Summary
As mentioned in #1217 talawa mobile app needs to be very reliable and is slowly inching toward complete test coverage. This issue solves #1530 and adds tests for the app localization file in utils folder.
Screenshots Supporting the PR