Fixes #1420 Models: Tests for event_model.dart #1452

Ayush0Chaudhary · 2023-01-31T15:36:26Z

What kind of change does this PR introduce?
It contains the test for event_model.dart

Issue Number:

Fixes #1420

Did you add tests for your changes?
YES

Summary
It contains the test for event_model.dart

Does this PR introduce a breaking change?
NO

Have you read the contributing guide?
YES

palisadoes · 2023-01-31T15:41:32Z

Please fix the failing tests. Merge with upstream.

Ayush0Chaudhary · 2023-01-31T16:09:13Z

@noman2002 @palisadoes please review.

Ayush0Chaudhary · 2023-01-31T16:10:15Z

Please fix the failing tests. Merge with upstream.

merged

codecov-commenter · 2023-01-31T17:51:11Z

Codecov Report

Merging #1452 (5f8e37e) into develop (6fdc10f) will increase coverage by 0.41%.
The diff coverage is n/a.

❗ Current head 5f8e37e differs from pull request most recent head 530f641. Consider uploading reports for the commit 530f641 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #1452      +/-   ##
===========================================
+ Coverage    71.85%   72.26%   +0.41%     
===========================================
  Files          146      146              
  Lines         7212     7212              
===========================================
+ Hits          5182     5212      +30     
+ Misses        2030     2000      -30

Impacted Files	Coverage Δ
lib/models/organization/org_info.dart	`44.44% <0.00%> (+11.11%)`	⬆️
lib/models/events/event_model.dart	`100.00% <0.00%> (+27.27%)`	⬆️
lib/models/post/post_model.dart	`100.00% <0.00%> (+38.63%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Ayush0Chaudhary · 2023-01-31T18:30:27Z

@noman2002 please review

noman2002

Why we need to add userinfo.hive and userinfo.lock

noman2002 · 2023-01-31T18:39:04Z

test/model_tests/chats/chat_message_test.dart

-import 'package:flutter_test/flutter_test.dart';
-import 'package:talawa/models/chats/chat_message.dart';
-import 'package:talawa/models/chats/chat_user.dart';
-
-final chatUserOne =
-    ChatUser(firstName: 'Ravidi', id: '1', image: "https://testimg.com");
-final chatUserTwo =
-    ChatUser(firstName: 'Sheikh', id: '2', image: "https://testimg.com");
-void main() {
-  group("Tests for ChatMessage.dart", () {
-    test('check if ChatMessage JSON serialization works', () {
-      final message =
-          ChatMessage('1', chatUserOne, 'Hello, how are you?', chatUserTwo);
-
-      final messageJson = message.toJson();
-
-      final messageFromJson = ChatMessage.fromJson(messageJson);
-
-      expect(messageFromJson.id, message.id);
-      expect(messageFromJson.sender!.firstName, message.sender!.firstName);
-      expect(messageFromJson.receiver!.id, message.receiver!.id);
-      expect(messageFromJson.messageContent, message.messageContent);
-    });
-  });
-}


Why you have deleted this file?

I think i did it by mistake
looking into it

their are two folder in model chat and chats

can we move all file of chat into chats
@noman2002

I am not sure why there are two folders. I guess their must be some purpose for it. Let it be for now.

noman2002 · 2023-01-31T18:59:38Z

Why we need to add userinfo.hive and userinfo.lock

what about these files ??

noman2002

Restore chat_message_test.dart

Ayush0Chaudhary · 2023-01-31T19:10:42Z

Restore chat_message_test.dart

done

Ayush0Chaudhary · 2023-01-31T19:13:07Z

Why we need to add userinfo.hive and userinfo.lock

what about these files ??

it is produced by this test test/model_tests/user/user_info_test.dart (I am not the author)
We should add it in the .gitignore

noman2002 · 2023-01-31T19:15:25Z

Why we need to add userinfo.hive and userinfo.lock

what about these files ??

it is produced by this test test/model_tests/user/user_info_test.dart (I am not the author) We should add it in the .gitignore

Okay got. I'll update it. No issues.

palisadoes · 2023-01-31T19:18:08Z

Why we need to add userinfo.hive and userinfo.lock

what about these files ??

it is produced by this test test/model_tests/user/user_info_test.dart (I am not the author) We should add it in the .gitignore

If the test is successful, then it should delete the file. Can you edit it to make sure that happens? It should also be generated in a temporary location outside of the code base. Is that possible?
If it is not possible then the file can remain, but must be deleted and added to .gitignore.

Ayush0Chaudhary · 2023-01-31T19:23:14Z

@noman2002 is the PR okay?

Why we need to add userinfo.hive and userinfo.lock

what about these files ??

it is produced by this test test/model_tests/user/user_info_test.dart (I am not the author) We should add it in the .gitignore

If the test is successful, then it should delete the file. Can you edit it to make sure that happens? It should also be generated in a temporary location outside of the code base. Is that possible?

If it is not possible then the file can remain, but must be deleted and added to .gitignore.

I'll look into 1st option and came back to you

palisadoes · 2023-01-31T19:28:13Z

Thanks. Many languages have packages that allow you to create temporary files independent of the OS. Many times you can add the .suffix of choice.

Ayush0Chaudhary · 2023-01-31T19:35:25Z

Added to temporaryPath which contain all the hive files @palisadoes @noman2002

Ayush0Chaudhary · 2023-01-31T19:38:48Z

test/model_tests/user/user_info_test.dart

@@ -185,7 +185,7 @@ void main() {

    test('Check if Hive storage works', () async {
      Hive
-        ..init("./data")
+        ..init("./temporaryPath")


previously it was storing in seprate folder named data and now it will store it in ./temporaryPath

@palisadoes @noman2002

This won't be a valid path for a Windows based developer. Any other suggestions?

@palisadoes @noman2002 I checked on my Windows machine and it was working

This method of storing hive file is used by other test also
for example

talawa/test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart

Lines 92 to 99 in 76f1553

final Directory dir = Directory('temporaryPath');

Hive

..init(dir.path)

..registerAdapter(UserAdapter())

..registerAdapter(OrgInfoAdapter());

await Hive.openBox<User>('currentUser');

await Hive.openBox<OrgInfo>('currentOrg');

await Hive.openBox('url');

and

talawa/test/widget_tests/after_auth_screens/profile/edit_profile_page_test.dart

Lines 79 to 86 in 76f1553

final Directory dir = Directory('temporaryPath');

Hive

..init(dir.path)

..registerAdapter(UserAdapter())

..registerAdapter(OrgInfoAdapter());

await Hive.openBox<User>('currentUser');

await Hive.openBox<OrgInfo>('currentOrg');

await Hive.openBox('url');

or I am not able to understand what you want to say. We are just making a file named temporaryPath. I think you misunderstood temporaryPath by /temp file provided in linux systems

OK, so we are using Hive to temporarily store data for testing, but in the lib/ directory. Should we create a test specific const for this for consistency? Like in here https://github.com/PalisadoesFoundation/talawa/tree/develop/test/helpers

Yes we can do something like this for consistency, maybe write all the hive init in one file and call them according to their requirement, instead of initialising Hive in each test case separately.
It will make our code more DRY.
@palisadoes @noman2002

if you like this idea, I'll like to complete this. maybe in this PR or or in separate issue

Please fix it in this PR

Ayush0Chaudhary · 2023-02-01T14:09:52Z

@noman2002 @palisadoes why is test failing?? Can you help??

Ayush0Chaudhary · 2023-02-01T18:19:50Z

@noman2002 is it a new problem or I did something wrong??
@palisadoes

noman2002 · 2023-02-01T18:22:11Z

@noman2002 is it a new problem or I did something wrong?? @palisadoes

Codecov problem. It happens.

palisadoes · 2023-02-01T20:43:21Z

@noman2002 Please review and merge if OK. CodeCov regenerated. I have noticed that when CodeCov fails, you have to delete the previous CodeCov comment an rerun the action.

Ayush0Chaudhary · 2023-02-01T21:04:47Z

@noman2002 please review

Ayush0Chaudhary · 2023-02-02T09:34:47Z

@noman2002 do I need to change something??

Ayush0Chaudhary added 2 commits January 31, 2023 19:00

Draft

9a300d4

Fixes PalisadoesFoundation#1420 Models: Tests for event_model.dart

c5fda49

Ayush0Chaudhary force-pushed the Ayush0Chaudhary/event_model_test branch from 2736289 to c5fda49 Compare January 31, 2023 15:38

Solved conflict

a54b52e

palisadoes requested a review from noman2002 January 31, 2023 16:51

noman2002 reviewed Jan 31, 2023

View reviewed changes

Ayush0Chaudhary added 2 commits February 1, 2023 00:22

add the deleted file

c90334d

remove the chat directory

60e02ed

remove data

fe7ca12

noman2002 requested changes Jan 31, 2023

View reviewed changes

changed the directory str to old one

13082e3

moved the unnecessary file to temporaryPath

5f8e37e

Ayush0Chaudhary commented Jan 31, 2023

View reviewed changes

palisadoes mentioned this pull request Feb 1, 2023

Problem with test folder structure #1455

Closed

Ayush0Chaudhary added 2 commits February 1, 2023 17:27

delete all the hive file after use

530f641

deleted file

3f0de6f

Ayush0Chaudhary force-pushed the Ayush0Chaudhary/event_model_test branch from 865b0ff to 3f0de6f Compare February 1, 2023 12:13

Merge branch 'develop' into Ayush0Chaudhary/event_model_test

ba8c459

Ayush0Chaudhary force-pushed the Ayush0Chaudhary/event_model_test branch from 3e54b60 to ba8c459 Compare February 1, 2023 12:22

setUp Hive helper

389a109

palisadoes approved these changes Feb 1, 2023

View reviewed changes

Ayush0Chaudhary requested a review from noman2002 February 2, 2023 14:41

palisadoes merged commit ed2925a into PalisadoesFoundation:develop Feb 2, 2023

	final Directory dir = Directory('temporaryPath');
	Hive
	..init(dir.path)
	..registerAdapter(UserAdapter())
	..registerAdapter(OrgInfoAdapter());
	await Hive.openBox<User>('currentUser');
	await Hive.openBox<OrgInfo>('currentOrg');
	await Hive.openBox('url');

Fixes #1420 Models: Tests for event_model.dart #1452

Fixes #1420 Models: Tests for event_model.dart #1452

Conversation

Ayush0Chaudhary commented Jan 31, 2023

palisadoes commented Jan 31, 2023

Ayush0Chaudhary commented Jan 31, 2023

Ayush0Chaudhary commented Jan 31, 2023

codecov-commenter commented Jan 31, 2023 • edited Loading

Codecov Report

Ayush0Chaudhary commented Jan 31, 2023

noman2002 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noman2002 commented Jan 31, 2023

noman2002 left a comment

Choose a reason for hiding this comment

Ayush0Chaudhary commented Jan 31, 2023

Ayush0Chaudhary commented Jan 31, 2023 • edited Loading

noman2002 commented Jan 31, 2023

palisadoes commented Jan 31, 2023

Ayush0Chaudhary commented Jan 31, 2023

palisadoes commented Jan 31, 2023

Ayush0Chaudhary commented Jan 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ayush0Chaudhary Jan 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ayush0Chaudhary Feb 1, 2023 • edited Loading

Choose a reason for hiding this comment

Ayush0Chaudhary Feb 1, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ayush0Chaudhary commented Feb 1, 2023

Ayush0Chaudhary commented Feb 1, 2023

noman2002 commented Feb 1, 2023

palisadoes commented Feb 1, 2023

Ayush0Chaudhary commented Feb 1, 2023

Ayush0Chaudhary commented Feb 2, 2023

codecov-commenter commented Jan 31, 2023 •

edited

Loading

Ayush0Chaudhary commented Jan 31, 2023 •

edited

Loading

Ayush0Chaudhary commented Jan 31, 2023 •

edited

Loading

Ayush0Chaudhary Jan 31, 2023 •

edited

Loading

Ayush0Chaudhary Feb 1, 2023 •

edited

Loading

Ayush0Chaudhary Feb 1, 2023 •

edited

Loading