-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added tests for scanQR on SetUrl Page #1255
added tests for scanQR on SetUrl Page #1255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov Report
@@ Coverage Diff @@
## develop #1255 +/- ##
===========================================
+ Coverage 60.48% 61.67% +1.18%
===========================================
Files 119 119
Lines 6206 6216 +10
===========================================
+ Hits 3754 3834 +80
+ Misses 2452 2382 -70
Continue to review full report at Codecov.
|
The code coverage for |
How's progress on this? |
Working on page navigation tests. Got little time these days, but will try to complete it in a day or two. |
Update: Test for Login button successfully implemented. Just SignUp button and validator test left. I will try to complete by today itself. |
@sudo-saksham thank you for the update. |
Can you get the files to 100% test coverage? How's progress? |
I'm trying my best. I've contacted Yasharth for the assistance where I'm facing issue. If we're able to work this out, otherwise I got it till 94.5%. I'm trying my best to make it 100%. |
Try Ritik Kumar Srivastava (@CyberWake), Sumitra Saksham (@sumitra19jha) and Rutvik Chandla (@rutvik11062000) on Slack. |
I've DM'ed them, but I guess they are busy. I'll let you know if I make any progress further, but for now I'd request you to merge the changes & if anyone comes up with the soln first maybe they can resolve this further. |
Sagar, please review and merge if OK. |
@Sagar2366 Please review and merge if OK |
What kind of change does this PR introduce?
Creating tests for Set Url page (on pressing scan QR)
Issue Number:
Fixes #1248
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
Other information
Creating a test when the user presses the QR iconButton in setUrl page.
Have you read the contributing guide?
Yes