Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests for scanQR on SetUrl Page #1255

Merged

Conversation

saksham-gt
Copy link
Contributor

What kind of change does this PR introduce?
Creating tests for Set Url page (on pressing scan QR)

Issue Number:
Fixes #1248

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?
No

Other information

Creating a test when the user presses the QR iconButton in setUrl page.

Have you read the contributing guide?
Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@codecov-commenter
Copy link

Codecov Report

Merging #1255 (539b53b) into develop (5a8a2c3) will increase coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1255      +/-   ##
===========================================
+ Coverage    60.48%   61.67%   +1.18%     
===========================================
  Files          119      119              
  Lines         6206     6216      +10     
===========================================
+ Hits          3754     3834      +80     
+ Misses        2452     2382      -70     
Impacted Files Coverage Δ
lib/views/main_screen.dart 100.00% <0.00%> (ø)
lib/views/pre_auth_screens/set_url.dart 91.81% <0.00%> (+0.90%) ⬆️
lib/view_model/main_screen_view_model.dart 65.02% <0.00%> (+2.02%) ⬆️
.../widgets_view_models/custom_drawer_view_model.dart 92.59% <0.00%> (+11.11%) ⬆️
lib/widgets/custom_drawer.dart 98.55% <0.00%> (+95.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8a2c3...539b53b. Read the comment docs.

@palisadoes
Copy link
Contributor

The code coverage for setURL. We need to get it to 100%. Please work on achieving that goal. Almost there!

@palisadoes
Copy link
Contributor

How's progress on this?

@saksham-gt
Copy link
Contributor Author

Working on page navigation tests. Got little time these days, but will try to complete it in a day or two.

@saksham-gt
Copy link
Contributor Author

Update: Test for Login button successfully implemented. Just SignUp button and validator test left. I will try to complete by today itself.

@Sagar2366 Sagar2366 added the test Testing application label Mar 11, 2022
@Sagar2366
Copy link
Contributor

@sudo-saksham thank you for the update.
We are looking forward for your first PR contribution and more.

@palisadoes
Copy link
Contributor

Can you get the files to 100% test coverage? How's progress?

@saksham-gt
Copy link
Contributor Author

I'm trying my best. I've contacted Yasharth for the assistance where I'm facing issue. If we're able to work this out, otherwise I got it till 94.5%. I'm trying my best to make it 100%.

@palisadoes
Copy link
Contributor

Try Ritik Kumar Srivastava (@CyberWake), Sumitra Saksham (@sumitra19jha) and Rutvik Chandla (@rutvik11062000) on Slack.

@saksham-gt
Copy link
Contributor Author

I've DM'ed them, but I guess they are busy. I'll let you know if I make any progress further, but for now I'd request you to merge the changes & if anyone comes up with the soln first maybe they can resolve this further.

@palisadoes palisadoes requested a review from Sagar2366 March 13, 2022 19:55
@palisadoes
Copy link
Contributor

Sagar, please review and merge if OK.

@palisadoes
Copy link
Contributor

@Sagar2366 Please review and merge if OK

@Sagar2366 Sagar2366 merged commit 07f925e into PalisadoesFoundation:develop Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Views: Create tests for set_url.dart
4 participants