fixed:#2072 Upgraded package @testing-library/user-event from 12.8.3 to 14.5.2 #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (82)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
|
@gurramkarthiknetha please fix the conflicting file changes |
Okay , please review the pr #3012 |
noman2002
reviewed
Jan 4, 2025
Comment on lines
154
to
+155
| "jest-location-mock": "^2.0.0", | ||
| "jest-preview": "^0.3.1", | ||
| "jest-preview": "^0.2.3", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR upgrades the @testing-library/user-event package from version 12.8.3 to 14.5.2 to resolve dependency issues, align with the latest features, and improve stability.
Issue Number:
Fixes #2072
Did you add tests for your changes?
Yes, existing tests were updated to comply with the new syntax and methods introduced in the upgraded version. Additional tests were added where necessary.
Snapshots/Videos:
Not applicable as this change primarily involves a dependency upgrade and test adjustments.
If relevant, did you update the documentation?
No updates were necessary for documentation as this is a dependency change that does not impact external documentation.
Summary
Upgraded @testing-library/user-event to 14.5.2.
Updated test cases to reflect new syntax and features.
Verified all tests pass to ensure compatibility.
Removed any redundant imports and resolved circular dependencies as per the release notes.
Does this PR introduce a breaking change?
No, this change does not introduce breaking changes to the application itself. It updates internal testing dependencies, ensuring they function correctly.
Other information
Release notes for 14.5.2 indicate resolved bugs, added named exports, and type improvements that enhance compatibility and developer experience.
Have you read the contributing guide?
Yes, I have reviewed and followed the contributing guidelines.
Summary by CodeRabbit
Based on the comprehensive summary, here are the release notes:
Dependencies
@testing-library/user-eventfrom^12.1.10to^14.5.2@testing-library/domat version^10.4.0jest-previewfrom^0.3.1to^0.2.3Testing Improvements
userEventimports from default to named imports across all test filesawaittouserEventmethod callsThese changes primarily focus on updating testing libraries and improving the robustness of test suites by ensuring proper handling of asynchronous user interactions.