Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/css navbar #12

Merged
merged 6 commits into from
Jan 5, 2025

Conversation

Abhi-MS
Copy link

@Abhi-MS Abhi-MS commented Jan 4, 2025

What kind of change does this PR introduce?

Update the site's CSS and NavBar

Issue Number:

Fixes #Part of 6

Did you add tests for your changes?

Basic visual checking.

Snapshots/Videos:

image
image

If relevant, did you update the documentation?

Not relevant

Summary

This PR updates the navbar and color scheme of the website

Does this PR introduce a breaking change?

No

Other information

docusaurus.config.ts was edited to add the navbar and footer items

Have you read the contributing guide?

Yes

palisadoes and others added 3 commits December 31, 2024 10:42
* Added new GitHub workflows

* Fixed talawa references

---------

Co-authored-by: Peter Harrison <[email protected]>
Copy link

github-actions bot commented Jan 4, 2025

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests and there are no merge conflicts.

The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@palisadoes
Copy link
Contributor

  1. The target branch is failing probably because you changed it in the PR
  2. Fix the conflicting file
  3. You'll need to do some research. The project is not community based. It is targeting network engineers, NetOps, DevOps, SysAdmins & SysOps. Please find images and artwork in your next PR to address this. The images in this PR are inappropriate in the short term. They will need to be changed soon.

These dependencies were causing issues
Setting the current hero image as transparent until next PR with more appropriate images.
@Abhi-MS
Copy link
Author

Abhi-MS commented Jan 5, 2025

@palisadoes Hi, the image was totally random to get the same layout as Hasura Docs website. But since it is not appropriate, I have set the image transparent for the moment until the next PR. Conflicts are now resolved. Please let me know if anything else needs to be changed for this PR.

@palisadoes palisadoes merged commit dd54f0c into PalisadoesFoundation:develop Jan 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants