Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[CRC] add docstring for analysis_inputs #228

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

sanbuphy
Copy link
Contributor

@sanbuphy sanbuphy commented Jul 1, 2023

#186

序号15

@paddle-bot
Copy link

paddle-bot bot commented Jul 1, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 1, 2023
@SigureMo SigureMo changed the title add docstring for analysis_inputs [CRC] add docstring for analysis_inputs Jul 1, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 3, 2023
):
) -> set[str]:
"""
Create a state object with empty sets for Analyzes the instructions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Create a state object with empty sets for Analyzes the instructions.
Create a state object with empty sets for analyzes the instructions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否从功能上描述这个函数是干什么的吗?描述逻辑是没有意义的

可参考 #125 #158 #173

@@ -30,6 +42,9 @@ def fork(
return walk(new_state, new_start)

def walk(state: State, start: int) -> set[str]:
"""
Performs the analysis of bytecode instructions recursively starting from a given start index.
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这就不用标注了吧

@SigureMo SigureMo added 🐾 meow 快乐喵喵开源活动专属认证 and removed 🐾 meow 快乐喵喵开源活动专属认证 labels Jul 11, 2023
@SigureMo SigureMo merged commit 0b46f84 into PaddlePaddle:develop Jul 13, 2023
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants