Skip to content

[RL] Fix typo and add wandb log #10641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

Conversation

gongel
Copy link
Member

@gongel gongel commented May 22, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Docs

PR changes

Docs

Description

  • Fix typo
  • Update RL README and default config

Copy link

paddle-bot bot commented May 22, 2025

Thanks for your contribution!

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.91%. Comparing base (dbf9c44) to head (01882c5).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/rl/trainer/ppo_trainer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10641   +/-   ##
========================================
  Coverage    46.91%   46.91%           
========================================
  Files          799      799           
  Lines       132460   132460           
========================================
  Hits         62140    62140           
  Misses       70320    70320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gongel gongel merged commit 7dbba98 into PaddlePaddle:develop May 23, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants