Skip to content

【PaddleNLP No.9】 Fix machine_reading_comprehension SQuAD #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

hanlintang
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Description

  1. ✅ Fix compatibility of the machine_reading_comprehension/SQuAD example with PIR (Paddle Intermediate Representation) to ensure successful model export and inference.

  2. 📘 Add guidance for:

  • Running with Python 3.8;
  • Manually downloading datasets (e.g., SQuAD v2.0) for environments without internet or Hugging Face access.

Modified:
slm/examples/machine_reading_comprehension/SQuAD/README.md
slm/examples/machine_reading_comprehension/SQuAD/deploy/python/predict.py

Issues: #9763 #10415
@DrownFish19 @ZHUI

Copy link

paddle-bot bot commented Apr 18, 2025

Thanks for your contribution!

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.99%. Comparing base (97b7af4) to head (d6d1256).
Report is 3 commits behind head on develop.

❌ Your project status has failed because the head coverage (48.99%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10445   +/-   ##
========================================
  Coverage    48.99%   48.99%           
========================================
  Files          765      765           
  Lines       125973   125973           
========================================
+ Hits         61716    61726   +10     
+ Misses       64257    64247   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DrownFish19 DrownFish19 added the HappyOpenSource 快乐开源活动issue与PR label Apr 20, 2025
Copy link
Collaborator

@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrownFish19 DrownFish19 merged commit 031ff47 into PaddlePaddle:develop Apr 21, 2025
10 of 12 checks passed
@hanlintang hanlintang deleted the squad branch April 21, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants