Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused cost parameter in ParameterUpdater #970

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Dec 20, 2016

No description provided.

@wangkuiyi
Copy link
Collaborator

赞! @reyoung

@@ -38,7 +38,7 @@ class ParameterUpdater {
virtual void startPass() {}

// called by Trainer then finishing a pass, ruturn true if pass accepted
virtual bool finishPass(real cost = 0) { return true; }
Copy link
Member

@jacquesqiao jacquesqiao Dec 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 cost一开始是用来做啥的,看起来是记录了每一个batch的cost,现在是使用另外一个机制替代了么

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

查看了下代码,应该只有在已删掉的 BatchRemoteParameterUpdater和 AsgdSparseGradientMachine的finishPass() 中的cost被parameterClient_传送该参数到pserver上,具体作用没有细查看。 目前版本该参数应该可以去掉。

@reyoung reyoung merged commit 4e34220 into PaddlePaddle:develop Dec 21, 2016
@reyoung reyoung deleted the feature/clean_parameter_updater_finish_pass branch December 21, 2016 03:17
zhhsplendid pushed a commit to zhhsplendid/Paddle that referenced this pull request Sep 25, 2019
* break up layers and change index of layers

* prettify script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants