Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix ]fix sample code in paddle.utils.require_version #57989

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Oct 10, 2023

PR types

Others

PR changes

Others

Description

link PaddlePaddle/docs#6220
在中文api_label修复过程中,发现缺失 require_version的中文文档,英文paddle.util.require_version 的示例代码使用的是 base。
link #57501 中也是确认过这个函数是暴露的

图片

@sunzhongkai588 @SigureMo

@paddle-bot
Copy link

paddle-bot bot commented Oct 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 10, 2023
@SigureMo
Copy link
Member

link #57501 中也是把这个函数暴露出来了

确认一下,这个 API 是之前就有的吧,不是这个 PR 才暴露的吧?如果是这个 PR 暴露了新的 API 是有问题的,因为该 PR 只应该修改 CodeStyle

@ooooo-create
Copy link
Contributor Author

link #57501 中也是把这个函数暴露出来了

确认一下,这个 API 是之前就有的吧,不是这个 PR 才暴露的吧?如果是这个 PR 暴露了新的 API 是有问题的,因为该 PR 只应该修改 CodeStyle

嗯嗯,是之前就有的。我想说这个 pr 确认过这个是暴露的😂,之前 f403 改 import * 的时候

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Oct 10, 2023
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~辛苦o师傅

@luotao1 luotao1 merged commit 39814af into PaddlePaddle:develop Oct 11, 2023
@ooooo-create ooooo-create deleted the ooooo/fix_sample_code_paddle.utils.require_version branch October 11, 2023 04:35
Frida-a pushed a commit to Frida-a/Paddle that referenced this pull request Oct 14, 2023
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 16, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants