Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in config_helpers unittest. #1163

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 17, 2017

  • It gets wrong command line arguments before.

* It gets wrong command line arguments before.
@reyoung reyoung requested a review from gangliao January 17, 2017 04:51
@gangliao
Copy link
Contributor

@reyoung 把这个也删了吧 /Users/liaogang/baidu/Paddle/python/paddle/trainer_config_helpers/tests/CMakeLists.txt

 if (PROTOBUF_3)

不然应该还是没有protobuf_equal这个参数

* Because currently Paddle only use protobuf 3.
@reyoung
Copy link
Collaborator Author

reyoung commented Jan 17, 2017

@gangliao Done.

@gangliao gangliao merged commit 010dd20 into PaddlePaddle:develop Jan 17, 2017
@reyoung reyoung deleted the feature/fix_error_msg_in_test_configHelpers branch February 24, 2017 06:42
lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024
…one (PaddlePaddle#1163)

* replace eval dataloader with train dataloader if eval_dataloader is None

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants