Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash #66

Merged
merged 4 commits into from
Nov 20, 2024
Merged

remove lodash #66

merged 4 commits into from
Nov 20, 2024

Conversation

lukeed
Copy link
Contributor

@lukeed lukeed commented Nov 12, 2024

Hi there 👋

lodash is a huge dependency & you were using a tiny portion of it. Really you just needed snakeCase -- the rest were native stand-ins w/ a lodash. prefix.

Ran tests locally & all were passing

@lukeed lukeed requested a review from a team as a code owner November 12, 2024 16:56
@danbillson
Copy link
Contributor

Hey @lukeed 👋

Thanks for your contribution! We'll review your change and get back to you shortly

@danbillson
Copy link
Contributor

Hey @lukeed

I'm happy with the changes you've made but we require all commits to be signed before merging, it might be possible to sign the older commit with something like

git rebase --signoff HEAD~2

@lukeed lukeed force-pushed the patch-1 branch 2 times, most recently from 04b1970 to 4d84abe Compare November 19, 2024 04:02
@lukeed
Copy link
Contributor Author

lukeed commented Nov 19, 2024

Sorry for the delay.

I ran the command, which doesn't seem to have done anything which is odd considering my others elsewhere are signed.
It may be because I did this PR inside a Codespace...?

I'm totally fine/happy if you'd rather cherry-pick the diffs. It's not an involved PR and I'd rather see this not get caught up in process-like things, especially when its my own doing 🙃

lukeed and others added 3 commits November 19, 2024 09:15
lodash is huge & you were using a tiny portion of its insignificant bits

Signed-off-by: Luke Edwards <[email protected]>
Signed-off-by: Luke Edwards <[email protected]>
@lukeed
Copy link
Contributor Author

lukeed commented Nov 19, 2024

Fixed. I was on a machine that didnt have a GPG configured 🤦

@danbillson danbillson merged commit 55951b2 into PaddleHQ:main Nov 20, 2024
6 checks passed
@danbillson
Copy link
Contributor

Great, thanks for your contribution here @lukeed this should give us a huge saving on bundle size

@lukeed lukeed deleted the patch-1 branch November 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants