v2.0.0-rc.0 - Edge runtime support and more. #45
Conversation
| @@ -4,9 +4,9 @@ | |||
| * Changes may be overwritten as part of auto-generation. | |||
| */ | |||
|
|
|||
| import { type ISubscriptionPreviewResponse, ISubscriptionResponse } from '../../../types'; | |||
There was a problem hiding this comment.
You can't do type imports in deno then?
There was a problem hiding this comment.
I don't think this is a deno runtime requirenent. There is a lint rule which preferred adding type keyword if they were types.
Somehow it stopped adding it now 🤷
| false, | ||
| ], | ||
| [ | ||
| 'InValid timestamp', |
There was a problem hiding this comment.
Spelling if you're worried about that sort of thing in a test 😄
| }); | ||
| EdgeRuntime.initialize(); | ||
| }); | ||
| test.each([ |
There was a problem hiding this comment.
Absolutely not a blocker. I find this so much easier to read and you get proper types for the test cases too
| byteHexMapping[i] = i.toString(16).padStart(2, '0'); | ||
| } | ||
|
|
||
| export class EdgeCrypto implements CryptoProvider { |
There was a problem hiding this comment.
Specifically the computeHmac function
There was a problem hiding this comment.
we do have a test to assert it is generating correct HMAC here
CHANGELOG.md
Outdated
| - Added support for Bun, deno and edge runtimes. | ||
| - Added support for edge runtime. |
There was a problem hiding this comment.
Did you mean to remove deno from here?
There was a problem hiding this comment.
Yup, I need to run some more tests before marking it as fully supported.
vijayasingam-paddle
dismissed stale reviews from mikeymike and samcolby
via
2b9ec68
vijayasingam-paddle
changed the title
2.0.0-rc.0 - 2024-09-26
Added
Changed
WebhooksValidator.isValidSignaturenow returns a promise.node-fetchto nativefetchAPI.