rover flight modes: Specify speed axis #3530
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ Manual modes require stick inputs from the user to drive the vehicle. | |
|
|
||
| The sticks provide the same "high level" control effects over direction and rate of movement in all manual modes: | ||
|
|
||
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling longitudinal speed) | ||
| - `Right stick left/right`: Rotate the rover to the left/right (controlling yaw rate). | ||
|
|
||
| The manual modes provide progressively increasing levels of autopilot support for maintaining a course, speed, and rate of turn, compensating for external factors such as slopes or uneven terrain. | ||
|
|
@@ -32,7 +32,7 @@ The manual modes provide progressively increasing levels of autopilot support fo | |
|
|
||
| ::: details Overview mode mapping to control effect | ||
|
|
||
| | Mode | Longitudinal speed | Yaw rate | Required measurements | | ||
| | ------------------------------ | ------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------- | | ||
| | [Manual](#manual-mode) | Directly map stick input to motor commands. | Directly map stick input to motor commands. | None. | | ||
| | [Acro](#acro-mode) | Directly map stick input to motor commands. | Stick input creates a yaw rate setpoint for the control system to regulate. | Yaw rate. | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,9 +18,9 @@ Manual modes require stick inputs from the user to drive the vehicle. | |||||
|
|
||||||
| The sticks provide the same "high level" control effects over direction and rate of movement in all manual modes: | ||||||
|
|
||||||
| - `Left stick up/down`: Drive the rover forwards/backwards (controlling longitudinal speed) | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| - `Left stick left/right`: Yaw the rover to the left/right (controlling yaw rate). | ||||||
| - `Right stick left/right`: Drive the rover left/right (controlling lateral speed). | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| The manual modes provide progressively increasing levels of autopilot support for maintaining a course, speed, and rate of turn, compensating for external factors such as slopes or uneven terrain. | ||||||
|
|
||||||
|
|
@@ -33,7 +33,7 @@ The manual modes provide progressively increasing levels of autopilot support fo | |||||
|
|
||||||
| ::: details Overview mode mapping to control effect | ||||||
|
|
||||||
| | Mode | Longitudinal/Lateral speed | Yaw rate | Required measurements | | ||||||
|
There was a problem hiding this comment. This case perhaps makes sense to keep as longitudinal. |
||||||
| | ------------------------------ | --------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------- | | ||||||
| | [Manual](#manual-mode) | Directly map stick input to motor commands. | Directly map stick input to motor commands. | None. | | ||||||
| | [Acro](#acro-mode) | Directly map stick input to motor commands. | Stick input creates a yaw rate setpoint for the control system to regulate. | Yaw rate. | | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess longitudinal is OK. I preferred the original. I.e. this means "controlling forward backward speed".
Why? Well when someone says longitudinal I'm thinking, now what does that mean? It's accurate, but not as immediately obvious as forwards/backwards.
So I'd prefer it done like this and as in https://github.com/PX4/PX4-user_guide/pull/3530/files#r1894469734
BUT you have broad ownership of this area, so if you strongly prefer longitudinal then please merge this as-is. Otherwise change.