Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding descriptions of tiltrotor and quadtailsitter #3469

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Perrrewi
Copy link
Contributor

@Perrrewi Perrrewi commented Nov 22, 2024

@hamishwillee
Copy link
Collaborator

This looks good, though I just pulled main and tried make px4_sitl gz_tiltrotor and got told that this was unknown target. Perhaps something wrong with my setup.

The reason I wanted to do that is the image above of the tailsitter looks like a quadplane. Is it the correct image?

If it is the correct image, is this ready to merge?

@Perrrewi Perrrewi changed the title Draft: Add vehicle descriptions Draft: Adding descriptions of tiltrotor and quadtailsitter Dec 4, 2024
@Perrrewi
Copy link
Contributor Author

Perrrewi commented Dec 4, 2024

This looks good, though I just pulled main and tried make px4_sitl gz_tiltrotor and got told that this was unknown target. Perhaps something wrong with my setup.

This is fine, we haven't merged the tiltrotor yet, it's still in review.

The reason I wanted to do that is the image above of the tailsitter looks like a quadplane. Is it the correct image?

If it is the correct image, is this ready to merge?

I tilted the rotors to make the image different from the standard vtol, I assume you meant that the tiltrotor looks like a standard_vtol?

The tailsitter is a quadtailsitter so I think the image is correct?

@hamishwillee
Copy link
Collaborator

I assume you meant that the tiltrotor looks like a standard_vtol?

Yes I did. The new image is much better! Sorry about the confusion. Can you please give me the PR number that this is waiting on - i.e. the one that means I can try these frames out.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Dec 4, 2024

Can you also please add a release note for this in https://docs.px4.io/main/en/releases/main.html#simulation

@Perrrewi
Copy link
Contributor Author

Perrrewi commented Dec 5, 2024

Can you also please add a release note for this in https://docs.px4.io/main/en/releases/main.html#simulation

Absolutely, thanks for the guidance!!

en/releases/main.md Outdated Show resolved Hide resolved
@Perrrewi Perrrewi changed the title Draft: Adding descriptions of tiltrotor and quadtailsitter Adding descriptions of tiltrotor and quadtailsitter Dec 18, 2024
Copy link

No flaws found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants