pid_tuning_guide_multicopter: adapt to Acro default rates having changed for tuning purposes in PX4 1.15 #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/px4-v1-15-public-changes-what-needs-docs/39850/4 |
| @@ -27,7 +27,21 @@ Manual control input is required (such as RC control, joystick): | |||
|
|
|||
There was a problem hiding this comment.
Thanks @MaEtUgR
I've updated the parameter values in the Acro mode doc here as well. It seems to me that otherwise users will be very disappointed when they try acro mode and it isn't much fun. Because of the existing diagrams in stick input I've suggested that they use the previous default as experienced users. Is this OK?
Further, this really only matters for manual tuning right? I.e. you don't need to worry about default values when autotuning?
…ged for tuning purposes in PX4 1.15
hamishwillee
force-pushed
the
maetugr/acro-tuning-rates
branch
from
feef280
to
fc6141b
Compare
|
No flaws found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PX4/PX4-Autopilot#22098
after reading https://discuss.px4.io/t/px4-v1-15-public-changes-what-needs-docs/39850/3