Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python3-venv so that virtual environment work can be done #354

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

saosebastiao
Copy link
Contributor

Hello, this pull request adds virtual environment support for the docker builds. This is necessary because newer versions of macos and ubuntu are using python3.12 by default and 3.12 blocks installation of pip dependencies using user level packages and require you to install all libraries using virtual environments. I'm currently working on a PR for this in PX4/PX4-Autopilot#23228, but cannot progress past the CI/CD failures which depend on this package being available.

@saosebastiao
Copy link
Contributor Author

@TSC21 I'm not sure if you're the right person to contact for this, but I would like to get this change merged as it's blocking progress on update local development build environments for newer ubuntu and macos versions. Could you take a look for review/merge?

@TSC21
Copy link
Member

TSC21 commented Jun 5, 2024

Can you please bring this change for all the base containers? Let's make sure this is consistent throughout all of them.

@saosebastiao
Copy link
Contributor Author

saosebastiao commented Jun 5, 2024

@TSC21 added them to rest of the base images. It seems like the others inherit the environment of the base images, so anything down in the hierarchy is unchanged.

How does the date-based tagging happen for the inheriting images? It seems like the base images have to be built with a tag before the downstream images can use the tag, so is a merge to a base image inherently a multi-PR process?

I do think that with the 6 year LTS cycle for ubuntu, we should probably introduce a new hierarchy for Ubuntu 24.04 (possibly 22.04 as well?), as the current latest (20.04-focal) is becoming less and less representative of the type of environment that developers are likely to be using. But maybe I can do that in a different PR.

@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-june-12-2024/39209/1

@dagar dagar merged commit 5483ce7 into PX4:master Jun 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants