Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PX4 builds releases using development.xml #23940

Open
hamishwillee opened this issue Nov 14, 2024 · 1 comment
Open

[Bug] PX4 builds releases using development.xml #23940

hamishwillee opened this issue Nov 14, 2024 · 1 comment

Comments

@hamishwillee
Copy link
Contributor

Describe the bug

PX4 builds releases using development.xml, when it should build them using common.xml. This is a bug because it creates a dependency in the release build on MAVLink messages and commands that can be changed or removed, breaking the old release.

PX4 should build with development.xml in main, and common.xml in release. The release cycle should then fix any errors caused by missing messages by either moving them into a (notional) "px4.xml" or better, by getting problematic messages into common.xml.

To Reproduce

Search code for CONFIG_MAVLINK_DIALECT - you can see that this is set in development in the release branch, such as here https://github.com/PX4/PX4-Autopilot/blob/release/1.15/boards/px4/fmu-v5x/default.px4board#L75

Expected behavior

A condition test of some kind that ensures that any release branch uses common.xml automatically.

Screenshot / Media

No response

Flight Log

No response

Software Version

NA

Flight controller

NA

Vehicle type

None

How are the different components wired up (including port information)

No response

Additional context

No response

@hamishwillee
Copy link
Contributor Author

@dagar I'd happily work on this, but don't know where you would start.

@github-actions github-actions bot added the stale label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant