-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check total cpu cores for the cpu_num var run_baseline_parallel.py #52
Conversation
The code now checks how much cpus the dev has and set the cpu_num equal to that amount.
Hm I'm torn on this. This is much better for booting up and running on a typical machine, but it also means the original results won't be reproducible without changing the code. Perhaps if I have the time (or someone else does) to verify that good results can still be obtained when running with much less environments, then I'd happily make this the default. |
I am happy to run an experiment in regards to seeing how much less environments impacts the quality of the results I did some quick performance tests by drastically reducing the episode length ect so the test could run in a reasonable timeframe and using num_cpu = 8 Finished in 72.54381019999983 seconds This is on a 16 core/ 32 thread cpu ( @PWhiddy Do you have a preference on how many agents I use for the experiment? |
@RussellMaggs |
When I apply this patch #1 I am now able to use num_cpu = os.cpu_count() * 6 and still have little headroom. *7 doesn't work well for me. M1pro. |
@RussellMaggs Dude... how did you get visualizations working.... The speed improvements mean you will catch up very quickly but you can of course train many more simultaneous agents to provide everyone better training metrics. |
I pretty much hacked at it until it worked and still have a poor understanding of how it works. If I have some free time I will see if I can provide some polish to the notebook so that it works better I think the biggest reason the Onto your second suggestion, I am happy to merge that in and spend some time running it but I am pretty busy for the next couple of days so it will have to be later |
I believe this is no longer an issue with the current optimizations #98 |
The code now checks how much cpus the dev has and set the cpu_num equal to that amount.