Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 3D no-slip boundary condition #187

Merged
merged 21 commits into from
Jul 4, 2024
Merged

Conversation

albert-de-montserrat
Copy link
Collaborator

Also adds tests for 3D BCs and some basic docs

Copy link
Collaborator

@aelligp aelligp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding this. Not quite sure why it would fail on the CPU and not on the GPU

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 4.25532% with 45 lines in your changes missing coverage. Please review.

Files Patch % Lines
src/boundaryconditions/no_slip.jl 0.00% 33 Missing ⚠️
src/Interpolations.jl 0.00% 8 Missing ⚠️
src/stokes/Stokes3D.jl 33.33% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9e6e0df) and HEAD (8da35ee). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (9e6e0df) HEAD (8da35ee)
9 3
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@albert-de-montserrat albert-de-montserrat merged commit 0682fc9 into main Jul 4, 2024
11 of 12 checks passed
@albert-de-montserrat albert-de-montserrat deleted the adm/3DBCs branch August 26, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants