-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework: Extensions #130
Merged
Merged
Rework: Extensions #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2D shear heating benchmark, 64x64, 2 threads, 3 time steps. This branch:
t1 = 13.703740 seconds # (20.70 M allocations: 1.396 GiB, 4.58% gc time, 74.67% compilation time); warm up run (includes compilation)
t2 = 4.833359 seconds # (4.83 M allocations: 412.365 MiB, 0.33% gc time); second run (no compilation)
#main
branch
t1 = 15.079457 seconds # (24.12 M allocations: 1.645 GiB, 6.54% gc time, 72.40% compilation time); warm up run (includes compilation)
t2 = 5.245096 seconds # (5.15 M allocations: 449.310 MiB, 0.31% gc time); second run (no compilation)
…ax.jl into adm/extensions
aelligp
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major rework
This PR involves a
decentfull rework of the internal design of JustRelax.jl.Main changes
ParallelStencil
. For example, the old initializationis deprecated in favour of
or
Extensions are used to switch from the CPU to supported GPU backends. This simplifies the setup of the package by removing lots of hacky and inefficient code, and improves pre-compilation. The user now just needs to choose between
CPUBackend
,CUDABackend
,AMDGPUBackend
to instantiate the basicJustRelax
objects.To ease a bit the usage of JustRelax and improve readibility, all the functions that required the
@parallel
macro are not exported anymore. Instead, wrappers around them are exported. E.g.substitutes the old