Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal Stresses #115

Merged
merged 59 commits into from
Apr 8, 2024
Merged

Thermal Stresses #115

merged 59 commits into from
Apr 8, 2024

Conversation

aelligp
Copy link
Collaborator

@aelligp aelligp commented Mar 13, 2024

This adds thermal stresses according to the implementation of Kiss et al. (2023)

$$\frac{\partial P^{\textrm{tr}}}{\partial \omega} = - \frac{\partial v_{\textrm{k}}}{\partial x_{\textrm{k}}} + \alpha \frac{dT}{dt} + \beta \frac{P^{\textrm{tr}} - P^{\textrm{old}}}{dt}$$

Few issues persist:

  • We don't solve for density the same way they did
$$\rho = \rho^{\textrm{old}} \exp(-\frac{\partial{v_k}}{\partial{x_k}} dt)$$

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 8 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/boundaryconditions/BoundaryConditions.jl 71.42% 2 Missing ⚠️
src/rheology/GeoParams.jl 75.00% 2 Missing ⚠️
src/stokes/PressureKernels.jl 88.23% 2 Missing ⚠️
src/thermal_diffusion/DiffusionPT.jl 50.00% 2 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@aelligp aelligp mentioned this pull request Mar 14, 2024
11 tasks
@aelligp
Copy link
Collaborator Author

aelligp commented Mar 18, 2024

Currently, the thermal stresses only work for incompressible rheologies and no free surface in the model setup.

000015

@aelligp aelligp marked this pull request as ready for review March 19, 2024 14:34
@boriskaus
Copy link
Collaborator

I don’t understand why a free surface should affect this. Can you elaborate?

@aelligp aelligp marked this pull request as draft April 3, 2024 12:45
@aelligp
Copy link
Collaborator Author

aelligp commented Apr 4, 2024

First look at the 3D setup of thermal stresses with a resolution of 128^3 after 6 time steps.

$$\tau_{\textrm{II}}$$

first3D_plot

@aelligp aelligp marked this pull request as ready for review April 5, 2024 15:17
Copy link
Collaborator

@albert-de-montserrat albert-de-montserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@albert-de-montserrat albert-de-montserrat merged commit f8e13c5 into main Apr 8, 2024
10 checks passed
@albert-de-montserrat albert-de-montserrat deleted the pa-thermalstresses branch April 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants