🩹 [Patch]: Use ArgumentCompleter and private variables
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Module [NerdFonts - v1.0.15-refresh1] published to the PowerShell Gallery. |
|
GitHub release for NerdFonts v1.0.15-refresh1 has been created. |
|
Module [NerdFonts - v1.0.15-refresh2] published to the PowerShell Gallery. |
|
GitHub release for NerdFonts v1.0.15-refresh2 has been created. |
|
Module [NerdFonts - v1.0.15] published to the PowerShell Gallery. |
|
GitHub release for NerdFonts v1.0.15 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the PowerShell scripts related to the installation and management of NerdFonts. The changes focus on removing dynamic parameters, adding argument completers, and refactoring the initialization of the NerdFonts list.
Key changes include:
Removal of Dynamic Parameters:
src/functions/public/Install-NerdFont.ps1: Removed the dynamic parameter block from theInstall-NerdFontfunction.Argument Completers:
src/functions/public/completers.ps1: Added a new argument completer for theInstall-NerdFontandGet-NerdFontcommands to provide auto-completion for theNameparameter.Initialization Refactoring:
src/init/initializer.ps1: Removed the initialization of the NerdFonts list from this file.src/variables/private/NerdFonts.ps1: Moved the initialization of the NerdFonts list to this file.Module Requirement Adjustment:
src/functions/public/Install-NerdFont.ps1: Adjusted the#Requiresstatement to remove theDynamicParamsmodule requirement.Type of change
Checklist