Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing env.variable #65

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

changing env.variable #65

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
793afb3
Update common_ci.properties
sac2kadam Nov 28, 2024
ddbe6d4
Update common_ci.properties
sac2kadam Nov 28, 2024
e737c5f
Update common_ci.properties
sac2kadam Nov 28, 2024
038f2b7
Merge branch 'develop' into develop
ravishanigarapu Nov 28, 2024
50dbebc
Merge branch 'PSMRI:develop' into develop
sac2kadam Nov 28, 2024
0d1aca6
Merge branch 'PSMRI:develop' into develop
sac2kadam Dec 4, 2024
231753b
Update common_ci.properties
sac2kadam Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/main/environment/common_ci.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,50 +6,50 @@ [email protected]_PASSWORD@
spring.datasource.driver-class-name=com.mysql.jdbc.Driver

## Carestream URLs, local
carestreamOrderCreateURL=@env.COMMON_API_BASE_URL@/carestream/createOrder
carestreamOrderCreateURL=@env.COMMON_API@/carestream/createOrder

## Identity - Common URLs
# Registration
registrationUrl =@env.COMMON_API_BASE_URL@/beneficiary/create
registrationUrl =@env.COMMON_API@/beneficiary/create

registrarQuickSearchByIdUrl =@env.COMMON_API_BASE_URL@/beneficiary/searchUserByID
registrarQuickSearchByIdUrl =@env.COMMON_API@/beneficiary/searchUserByID

registrarQuickSearchByPhoneNoUrl =@env.COMMON_API_BASE_URL@/beneficiary/searchUserByPhone
registrarQuickSearchByPhoneNoUrl =@env.COMMON_API@/beneficiary/searchUserByPhone

getBenImageFromIdentity [email protected]_API_BASE_URL@/id/benImageByBenRegID

beneficiaryEditUrl =@env.COMMON_API_BASE_URL@/beneficiary/update
beneficiaryEditUrl =@env.COMMON_API@/beneficiary/update

registrarAdvanceSearchUrl =@env.COMMON_API_BASE_URL@/beneficiary/searchBeneficiary
registrarAdvanceSearchUrl =@env.COMMON_API@/beneficiary/searchBeneficiary

## Data Sync API, central
dataSyncUploadUrl=@env.MMU_API_BASE_URL@/dataSync/van-to-server
dataSyncUploadUrl=@env.MMU_API@/dataSync/van-to-server

## Data download API, central
dataSyncDownloadUrl=@env.MMU_API_BASE_URL@/dataSync/server-to-van
dataSyncDownloadUrl=@env.MMU_API@/dataSync/server-to-van

## TC specialist slot booking, # not required
tcSpecialistSlotBook=@env.TM_API_BASE_URL@/schedule/bookSlot
tcSpecialistSlotBook=@env.TM_API@/schedule/bookSlot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Environment variable standardization is incomplete

The migration to TM_API is only partially implemented:

  • Only CI environment (common_ci.properties) uses @env.TM_API@
  • DEV and TEST environments use placeholder URLs
  • Example environment uses hardcoded IP addresses
  • UAT environment is missing these configurations entirely
🔗 Analysis chain

Verify the impact of TM_API environment variable change.

The change from TM_API_BASE_URL to TM_API affects telemedicine specialist slot management. This standardization needs careful verification.

Also applies to: 35-35

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining instances of TM_API_BASE_URL to ensure complete migration
echo "Checking for any remaining TM_API_BASE_URL references..."
rg "TM_API_BASE_URL" --type properties

# Search deployment scripts and documentation for environment variable definitions
echo "Checking deployment configurations..."
fd -e yaml -e yml -e sh -e md -X rg "TM_API(_BASE_URL)?"

Length of output: 340

Script:

#!/bin/bash
# Search for both old and new environment variable references
echo "Searching for TM_API_BASE_URL references..."
rg "TM_API_BASE_URL"

echo -e "\nSearching for TM_API references..."
rg "TM_API[^_]" -A 1

echo -e "\nChecking configuration and properties files..."
fd -e properties -e conf -e config -e env -e yaml -e yml

Length of output: 1010

Script:

#!/bin/bash
# Check slot booking related properties across all environment files
echo "Checking slot booking properties across environments..."
for file in src/main/environment/common_*.properties; do
    echo -e "\nFile: $file"
    rg "tcSpecialist(SlotBook|SlotCancel)" "$file" -A 1
done

Length of output: 2252


## TC specialist slot cancelling, # not required
tcSpecialistSlotCancel=@env.TM_API_BASE_URL@/schedule/cancelBookedSlot
tcSpecialistSlotCancel=@env.TM_API@/schedule/cancelBookedSlot

## benGenUrl, common, central
benGenUrlCentral=@env.COMMON_API_BASE_URL@/beneficiary/generateBeneficiaryIDs
benGenUrlCentral=@env.COMMON_API@/beneficiary/generateBeneficiaryIDs

## benImportUrl, identity, local
[email protected]_API_BASE_URL@/id/saveGeneratedBenIDToLocalServer
mmucentralserver = @env.MMU_CENTRAL_SERVER@/common/get/Case-sheet/centralServerTMCaseSheet

tmCentralServer = @env.TM_CENTRAL_SERVER@/common/get/Case-sheet/printData

specialistSign=@env.COMMON_API_BASE_URL@/signature1/getSignClass
specialistSign=@env.COMMON_API@/signature1/getSignClass

## inventory transaction download URL, central, mmu
dataSyncTransactionDownloadUrl=@env.MMU_API_BASE_URL@/dataSync/server-to-van-transactional
dataSyncTransactionDownloadUrl=@env.MMU_API@/dataSync/server-to-van-transactional

## inventory transaction processed flag update URL, central, mmu
dataSyncProcessedFlagUpdate=@env.MMU_API_BASE_URL@/dataSync/updateProcessedFlagPostDownload
dataSyncProcessedFlagUpdate=@env.MMU_API@/dataSync/updateProcessedFlagPostDownload


fileBasePath [email protected]_FILE_BASE_PATH@
Expand All @@ -71,10 +71,10 @@ [email protected]_SYNC_SERVER_USERNAME@
[email protected]_SYNC_SERVER_PASSWORD@
[email protected]_FOLDER_TO_SYNC@
serverFolder=MMUSync
getServerCredentialURL=@env.MMU_API_BASE_URL@/fileSyncController/getServerCredential
getServerCredentialURL=@env.MMU_API@/fileSyncController/getServerCredential
tmReferCheckValue=TM
### Redis IP
spring.redis.host=localhost

#ELK logging file name
[email protected]_API_LOGGING_FILE_NAME@
[email protected]_API_LOGGING_FILE_NAME@
Loading