Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Add CI configuration for build and relevant package scripts #67

Merged
merged 5 commits into from
Oct 25, 2023

Conversation

drtechie
Copy link
Member

@drtechie drtechie commented Oct 9, 2023

  • Added CI template that generates environment.ci.ts as per variables configured.
  • Added package scripts that generates build based on --configuration=ci.

@drtechie
Copy link
Member Author

drtechie commented Oct 9, 2023

Relates to #66

Marking this PR as [WIP] as there are open questions wrt build.

@drtechie drtechie changed the title [WIP] Add CI configuration for build and relevant package scripts Add CI configuration for build and relevant package scripts Oct 10, 2023
@drtechie
Copy link
Member Author

As per discussion in the linked issue #66, following additional changes have been made:

  1. Remove grunt
  2. Added CI profile in mvn
  3. Edited README with build instructions

@devikasuresh20 devikasuresh20 self-requested a review October 19, 2023 10:54
Copy link
Member

@devikasuresh20 devikasuresh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine.
But requesting for one change: 'Currently we are using the name "hwc-facility-app" for hwc-ui war. Please use this name instead of "hwcui"'.

Copy link
Member

@devikasuresh20 devikasuresh20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Sweta, please confirm about the corresponding API change and testing of application login functionality.

@drtechie
Copy link
Member Author

@devikasuresh20 changed the name of the artifact to hwc-app-facility.

Regarding the comment about API, only the build and packaging of the application have been changed.
Otherwise, let me know what and how to test.

@drtechie
Copy link
Member Author

https://github.com/PSMRI/HWC-UI/tree/develop/.github/workflows

The GitHub workflows folder has at least 2 files that don't have yaml extension.
@devikasuresh20 are they needed?
If yes, will change to .yaml, else delete the files.

@devikasuresh20 devikasuresh20 merged commit 5ece9d0 into PSMRI:develop Oct 25, 2023
2 checks passed
@devikasuresh20
Copy link
Member

https://github.com/PSMRI/HWC-UI/tree/develop/.github/workflows

The GitHub workflows folder has at least 2 files that don't have yaml extension. @devikasuresh20 are they needed? If yes, will change to .yaml, else delete the files.

I think it's required. As per the commits @Vidyaaa24 added it.

@drtechie
Copy link
Member Author

@devikasuresh20
https://github.com/PSMRI/HWC-UI/actions
GitHub Actions is not reading those files because it doesn't have a valid format.

@Vidyaaa24
Copy link
Contributor

https://github.com/PSMRI/HWC-UI/tree/develop/.github/workflows
The GitHub workflows folder has at least 2 files that don't have yaml extension. @devikasuresh20 are they needed? If yes, will change to .yaml, else delete the files.

I think it's required. As per the commits @Vidyaaa24 added it.

all github actions files should have .yml extension I think it is missed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants