-
Notifications
You must be signed in to change notification settings - Fork 18
Add CI configuration for build and relevant package scripts #67
Conversation
Relates to #66 Marking this PR as [WIP] as there are open questions wrt build. |
As per discussion in the linked issue #66, following additional changes have been made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks fine.
But requesting for one change: 'Currently we are using the name "hwc-facility-app" for hwc-ui war. Please use this name instead of "hwcui"'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with Sweta, please confirm about the corresponding API change and testing of application login functionality.
@devikasuresh20 changed the name of the artifact to hwc-app-facility. Regarding the comment about API, only the build and packaging of the application have been changed. |
https://github.com/PSMRI/HWC-UI/tree/develop/.github/workflows The GitHub workflows folder has at least 2 files that don't have yaml extension. |
I think it's required. As per the commits @Vidyaaa24 added it. |
@devikasuresh20 |
all github actions files should have .yml extension I think it is missed |
environment.ci.ts
as per variables configured.--configuration=ci
.