Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jwt implementation #61

Closed
wants to merge 1 commit into from
Closed

jwt implementation #61

wants to merge 1 commit into from

Conversation

indraniBan
Copy link
Contributor

@indraniBan indraniBan commented Dec 2, 2024 •
edited by coderabbitai bot
Loading

📋 Description

JIRA ID:

Please provide a summary of the change and the motivation behind it. Include relevant context and details.

✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced JWT authentication with new configuration entries for secret management across various environments.
    • Added new dependencies for enhanced JWT handling.
    • Implemented a utility class for managing cookies and JWT tokens.
    • Added a filter for JWT user ID validation on API requests.

  • Bug Fixes

    • Improved readability and consistency in configuration files.

  • Documentation

    • Updated properties and configurations in application.properties for better service integration.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request include updates to the pom.xml for dependency management, introducing new JWT-related dependencies and enhancing the formatting of existing entries. Multiple properties files have been modified to include a new jwt.secret entry for managing JWT authentication across different environments. Additionally, several new Java classes and interfaces have been added to implement JWT functionality, including utilities for token generation, validation, and cookie management, as well as a filter for user ID validation.

Changes

File Path Change Summary
pom.xml Added dependencies: jjwt-api, jjwt-impl, jjwt-jackson (version 0.11.5, runtime scope). Reformatted existing dependency entries for consistency.
src/main/environment/admin_ci.properties Added property: jwt.secret=<Enter_Your_Secret_Key>.
src/main/environment/admin_dev.properties Added property: jwt.secret=<Enter_Your_Secret_Key>.
src/main/environment/admin_example.properties Added property: jwt.secret=<Enter_Your_Secret_Key>.
src/main/environment/admin_test.properties Added property: jwt.secret=<Enter_Your_Secret_Key>.
src/main/environment/admin_uat.properties Added property: jwt.secret=<Enter_Your_Secret_Key>.
src/main/java/com/iemr/admin/repository/user/UserLoginRepo.java Added interface: UserLoginRepo with method getUserByUserID(@Param("userID") Long userID).
src/main/java/com/iemr/admin/utils/CookieUtil.java Added class: CookieUtil with methods for cookie management: getCookieValue, addJwtTokenToCookie, getJwtTokenFromCookie.
src/main/java/com/iemr/admin/utils/FilterConfig.java Added class: FilterConfig with method jwtUserIdValidationFilter for JWT user ID validation filter registration.
src/main/java/com/iemr/admin/utils/JwtAuthenticationUtil.java Added class: JwtAuthenticationUtil with methods for JWT validation: validateJwtToken, validateUserIdAndJwtToken.
src/main/java/com/iemr/admin/utils/JwtUserIdValidationFilter.java Added class: JwtUserIdValidationFilter for validating JWT tokens and managing user ID cookies.
src/main/java/com/iemr/admin/utils/JwtUtil.java Added class: JwtUtil with methods for JWT management: generateToken, validateToken, extractUsername, extractClaim.
src/main/resources/application.properties Added properties for database configuration, new API URLs, Redis host, and jwt.secret. Updated common-url.

Poem

In the garden where secrets bloom,
A token's trust dispels the gloom.
With cookies sweet and JWTs bright,
Our paths are safe, our futures light.
Hops of joy, let’s celebrate,
For every change, we elevate! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fc08c9e and 859956b.

📒 Files selected for processing (13)
  • pom.xml (7 hunks)
  • src/main/environment/admin_ci.properties (1 hunks)
  • src/main/environment/admin_dev.properties (1 hunks)
  • src/main/environment/admin_example.properties (1 hunks)
  • src/main/environment/admin_test.properties (1 hunks)
  • src/main/environment/admin_uat.properties (1 hunks)
  • src/main/java/com/iemr/admin/repository/user/UserLoginRepo.java (1 hunks)
  • src/main/java/com/iemr/admin/utils/CookieUtil.java (1 hunks)
  • src/main/java/com/iemr/admin/utils/FilterConfig.java (1 hunks)
  • src/main/java/com/iemr/admin/utils/JwtAuthenticationUtil.java (1 hunks)
  • src/main/java/com/iemr/admin/utils/JwtUserIdValidationFilter.java (1 hunks)
  • src/main/java/com/iemr/admin/utils/JwtUtil.java (1 hunks)
  • src/main/resources/application.properties (3 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
E Security Rating on New Code (required ≥ A)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 2, 2024
View reviewed changes
src/main/resources/application.properties
# DB Connections
spring.datasource.url=jdbc:mysql://192.168.45.22:3306/db_iemr?autoReconnect=true&useSSL=false&allowPublicKeyRetrieval=true
spring.datasource.username=piramaldev
spring.datasource.password=Piramal@2017

Check failure

Code scanning / SonarCloud

Credentials should not be hard-coded High

Revoke and change this password, as it is compromised. See more on SonarQube Cloud
@indraniBan indraniBan closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravishanigarapu ravishanigarapu Awaiting requested review from ravishanigarapu

@sandipkarmakar3 sandipkarmakar3 Awaiting requested review from sandipkarmakar3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@indraniBan