Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openpyxl to environment file #2703

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Add openpyxl to environment file #2703

merged 3 commits into from
Nov 3, 2023

Conversation

milinddethe15
Copy link
Contributor

fixes #2702

@jdebacker
Copy link
Member

Thanks of the PR @milinddethe15!

@jdebacker
Copy link
Member

@milinddethe15 Can you add openpyxl to the list of dependencies used to build the package in Tax-Calculator/conda.recipe/meta.yaml?

I think with that, all tests should pass.

added openpyxl to the list of dependencies used to build the package
@jdebacker
Copy link
Member

I'm sorry - one more time @milinddethe15 - the openpyxl dependency will need to be listed in the run list also in meta.yml

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2703 (838641d) into master (4c54366) will not change coverage.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2703   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files          14       14           
  Lines        2609     2609           
=======================================
  Hits         2571     2571           
  Misses         38       38           
Flag Coverage Δ
unittests 98.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdebacker
Copy link
Member

@milinddethe15 Thank you for this PR! Merging.

@jdebacker jdebacker merged commit b1eb957 into PSLmodels:master Nov 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add openpyxl to environment file
2 participants