Skip to content

Commit

Permalink
Try placeholder sns instead of description changes
Browse files Browse the repository at this point in the history
  • Loading branch information
cavis committed Dec 19, 2023
1 parent b16ae75 commit ef96943
Show file tree
Hide file tree
Showing 11 changed files with 22 additions and 11 deletions.
3 changes: 2 additions & 1 deletion spire/templates/shared-ecs/asg-sg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Transform: AWS::Serverless-2016-10-31

Description: >-
Creates the primary security group for the shared ECS ASG instances. It is
created here in a discrete stack to prevent some circular dependencies
created here in a discrete stack to prevent some circular dependencies.
Parameters:
EnvironmentType: { Type: String }
Expand All @@ -14,6 +14,7 @@ Parameters:
LoadBalancerSecurityGroupId: { Type: AWS::EC2::SecurityGroup::Id }

Resources:
Placeholder: { Type: AWS::SNS::Topic }
InstanceSecurityGroup:
Type: AWS::EC2::SecurityGroup
Properties:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-ecs/asg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Description: >-
cluster. Also creates a capacity provider associated with the shared ECS
cluster that helps manage the size of the ASG. Instances launched from the
ASG allow all outbound traffic. Inbound traffic is permitted using several
security groups. Instances in the ASG are launched in public subnets
security groups. Instances in the ASG are launched in public subnets.
Parameters:
kStagingImageId:
Expand Down Expand Up @@ -54,6 +54,7 @@ Conditions:
KeepAsgAlive: !And [!Condition IsProduction, !Condition IsPrimaryRegion]

Resources:
Placeholder: { Type: AWS::SNS::Topic }
InstanceProfile:
Type: AWS::IAM::InstanceProfile
Properties:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-redis/cluster.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ AWSTemplateFormatVersion: "2010-09-09"
Description: >-
Creates a Redis cluster intended to be used by several applications. The
cluster's security group will allow only traffic from a security group
provided as a stack parameter
provided as a stack parameter.
Parameters:
RootStackName: { Type: String }
Expand All @@ -21,6 +21,7 @@ Conditions:
IsProduction: !Equals [!Ref EnvironmentType, Production]

Resources:
Placeholder: { Type: AWS::SNS::Topic }
RedisSubnetGroup:
Type: AWS::ElastiCache::SubnetGroup
Properties:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-redis/security-groups.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Transform: AWS::Serverless-2016-10-31
Description: >-
Creates security groups for the shared Redis cluster and for the clients that
connect to the cluster. They are created in this stack to prevent circular
dependencies
dependencies.
Parameters:
EnvironmentType: { Type: String }
Expand All @@ -14,6 +14,7 @@ Parameters:
VpcId: { Type: AWS::EC2::VPC::Id }

Resources:
Placeholder: { Type: AWS::SNS::Topic }
# The Redis cluster belongs to this security group. It allows traffic from
# the client security group.
ClusterSecurityGroup:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-vpc/flow-logs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# stacks/shared-vpc/flow-logs.yml
AWSTemplateFormatVersion: "2010-09-09"

Description: Creates VPC flow logs for the shared VPC
Description: Creates VPC flow logs for the shared VPC.

Parameters:
EnvironmentType: { Type: String }
Expand All @@ -13,6 +13,7 @@ Conditions:
IsProduction: !Equals [!Ref EnvironmentType, Production]

Resources:
Placeholder: { Type: AWS::SNS::Topic }
FlowLogGroup:
Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-vpc/gateway-endpoints.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# stacks/shared-vpc/gateway-endpoints.yml
AWSTemplateFormatVersion: "2010-09-09"

Description: Creates various Gateway VPC endpoints in the shared VPC.
Description: Creates various Gateway VPC endpoints in the shared VPC

Parameters:
EnvironmentType: { Type: String }
Expand All @@ -14,6 +14,7 @@ Parameters:

# https://docs.aws.amazon.com/vpc/latest/userguide/vpce-gateway.html
Resources:
Placeholder: { Type: AWS::SNS::Topic }
S3Endpoint:
Type: AWS::EC2::VPCEndpoint
Properties:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-vpc/interface-endpoints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Description: >-
Creates various Interface VPC endpoints in the shared VPC. These are
primarily intended to support access for instances and tasks in private
networks, but are also utilized by instances and tasks in public networks by
virtue of how the Endpoints function
virtue of how the Endpoints function.
Parameters:
EnvironmentType: { Type: String }
Expand Down Expand Up @@ -56,6 +56,7 @@ Parameters:

# https://docs.aws.amazon.com/vpc/latest/userguide/vpce-interface.html
Resources:
Placeholder: { Type: AWS::SNS::Topic }
# Each XxxEndpointsAccessSecurityGroup is designed so that resources, such as
# EC2 instances, ECS tasks, Lambda functions, etc, can be added to the group
# and have access to the associated VPC Endpoint service or services.
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-vpc/private-network-acl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ AWSTemplateFormatVersion: "2010-09-09"

Description: >-
Creates a Network ACL and rules for subnets of the private subnets in the
shared VPC
shared VPC.
Parameters:
EnvironmentType: { Type: String }
Expand All @@ -14,6 +14,7 @@ Parameters:
VpcIpv6CidrBlocks: { Type: CommaDelimitedList }

Resources:
Placeholder: { Type: AWS::SNS::Topic }
PrivateNetworkAcl:
Type: AWS::EC2::NetworkAcl
Properties:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-vpc/private-subnets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ AWSTemplateFormatVersion: "2010-09-09"

Description: >-
Creates private subnets in the shared VPC, which have no internet gateway,
and a route table for the subnets
and a route table for the subnets.
Parameters:
EnvironmentType: { Type: String }
Expand All @@ -16,6 +16,7 @@ Parameters:
NetworkAclName: { Type: String }

Resources:
Placeholder: { Type: AWS::SNS::Topic }
AvailabilityZoneSelectorService:
Type: Custom::AvailabilityZoneSelector
Properties:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-vpc/public-network-acl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ AWSTemplateFormatVersion: "2010-09-09"

Description: >-
Creates a Network ACL and rules for subnets of the public subnets in the
shared VPC
shared VPC.
Parameters:
EnvironmentType: { Type: String }
Expand All @@ -14,6 +14,7 @@ Parameters:
VpcIpv6CidrBlocks: { Type: CommaDelimitedList }

Resources:
Placeholder: { Type: AWS::SNS::Topic }
PublicNetworkAcl:
Type: AWS::EC2::NetworkAcl
Properties:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/shared-vpc/public-subnets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ AWSTemplateFormatVersion: "2010-09-09"

Description: >-
Creates public subnets in the shared VPC, along with the internet gateway
that makes them public, and a route table for the subnets and gateway
that makes them public, and a route table for the subnets and gateway.
Parameters:
EnvironmentType: { Type: String }
Expand All @@ -16,6 +16,7 @@ Parameters:
NetworkAclName: { Type: String }

Resources:
Placeholder: { Type: AWS::SNS::Topic }
AvailabilityZoneSelectorService:
Type: Custom::AvailabilityZoneSelector
Properties:
Expand Down

0 comments on commit ef96943

Please sign in to comment.