Added new tests vacancy #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yakser
requested changes
Oct 29, 2023
vacancy/tests.py
Outdated
| user.save() | ||
| return user | ||
|
|
||
| def second_user_create(self): |
There was a problem hiding this comment.
можешь в user_create добавить аргументом user_create_data и удалить вторую функцию
меньше копипаста
There was a problem hiding this comment.
переименовать бы в create_user
хз почему у нас такое название завелось но это неправильно)
There was a problem hiding this comment.
поправил названия функций + вынес в TestUtils.
vacancy/tests.py
Outdated
| user.save() | ||
| return user | ||
|
|
||
| def project_create(self, user): |
There was a problem hiding this comment.
лучше переименовать в create_project
во вторых эти utils функции нужно куда то вынести из тест кейса, по хорошему user_create тоже вынести
vacancy/tests.py
Outdated
| ) | ||
| return project | ||
|
|
||
| def vacancy_create(self, project): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Краткое название
new tests for vacancy
Описание изменений
Добавил тесты на отклик на вакансию/ принятие отклика/ отклонение отклика/ удаление вакансии от владельца проекта/ пользователя/неавторизованного пользователя