Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node 16 #421

Closed
thewilkybarkid opened this issue Oct 21, 2021 · 3 comments
Closed

Use Node 16 #421

thewilkybarkid opened this issue Oct 21, 2021 · 3 comments

Comments

@thewilkybarkid
Copy link
Member

Node 16 is about to become the LTS version (2021-10-26). This also involves bumping NPM from 6 to 8.
@thewilkybarkid
Copy link
Member Author

Seems like #406 is a blocker, as the lockfile upgrade fails on the forks.

thewilkybarkid added a commit that referenced this issue Oct 21, 2021
@thewilkybarkid
build: remove dev fixtures
64e7259 
The generated data fixtures in the dev environment aren't helpful as they're not realistic. But worse, there are quite a few problems in this area:

- It fails to run roughly half the time.
- The forked dependency is blocking npm updates.
- The ORM overall is blocking Parcel updates.

Rather than trying to resolve all the issues, this change removes the fixture generation entirely. As a result, the codebase is a fraction simpler.

Refs #399, #406, #421
@thewilkybarkid
Copy link
Member Author

Now #399 is a blocker, as the older version of Sharp doesn't build.

thewilkybarkid added a commit that referenced this issue Nov 8, 2021
@thewilkybarkid
build: pin Alpine version
3273acf 
The default Alpine version has changed from 3.11 to 3.14, which seems to have a different setup leading to the Sharp build not working (which seems similar to the failures when trying to upgrade Node to version 16). This change pins the version to the highest supported version that still works without any other adjustments.

Refs nodejs/docker-node#1596, #421 (comment)
@thewilkybarkid
Copy link
Member Author

Following 3273acf, it seems that it's the newer versions of Alpine that stopped older versions of Sharp from building.

thewilkybarkid added a commit that referenced this issue Nov 9, 2021
@thewilkybarkid
build: use Node 16
bf1ef5c 
Refs #421
@thewilkybarkid thewilkybarkid mentioned this issue Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewilkybarkid