Author requests aren't properly authorised #425
Labels
bug
Something isn't working
Comments
thewilkybarkid
added a commit
that referenced
this issue
Nov 11, 2021
thewilkybarkid
added a commit
that referenced
this issue
Nov 11, 2021
CI started to fail with database connection problems; I could recreate this locally using Jest's --runInBand option. For an unknown reason, it doesn't like persisting data in the beforeAll step when only using a single worker. As a result, I've had to create these groups explicitly when needed. Refs 31ff753, #388, #425
thewilkybarkid
added a commit
that referenced
this issue
Nov 11, 2021
This change adds missing await statements. This change doesn't fix the skipped tests, only changing the result from a crash application to a 500 response. Refs #425
thewilkybarkid
added a commit
that referenced
this issue
Nov 11, 2021
The thisUser.isMemberOf function expects a user's ID rather than a persona. Worse, authorPersona is an ORM reference to the persona rather than the persona itself, so the uuid property is undefined. This change fixes the argument, resulting in passing tests. Refs #425
thewilkybarkid
added a commit
that referenced
this issue
Nov 12, 2021
When creating a new request, the API currently doesn't return any information when it succeeds. This change adds the request itself to the response, so the user doesn't have to look it up separately. This also then matches other endpoints. Refs #425
thewilkybarkid
added a commit
that referenced
this issue
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The authorisation logic for author requests is broken: any user can request one. Following the upgrade to Node 16 (#421), the app actually now crashes (due to an unhandled promise rejection).
The text was updated successfully, but these errors were encountered: