Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile: Fixes Issue #2 #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Makefile: Fixes Issue #2 #3

wants to merge 1 commit into from

Conversation

arnejasaksham
Copy link

Added: "go get github.com/PRETgroup/easy-rv/rvc" in the recipe for easy-rv-c

@arnejasaksham
Update Makefile
9d447bb 
Added: "go get github.com/PRETgroup/easy-rv/rvc" in the recipe for easy-rv-c
@arnejasaksham arnejasaksham mentioned this pull request May 8, 2020
Closed
kiwih
kiwih reviewed May 9, 2020
View reviewed changes
Copy link
Member

@kiwih kiwih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the general idea is that a user should clone the entire repository before attempting to use, thoughts? At any rate, if we add the go get for just one of the two sub-repos, we should probably add it for the other as well

@kiwih
Copy link
Member

kiwih commented May 9, 2020 •
edited
Loading

Also, I'm confused, your commit message mentions easy-rv but the change is to easy-rte?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiwih kiwih kiwih left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnejasaksham @kiwih