-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add robot name and type args in app_manager #54
base: kinetic-devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an author of https://github.com/ros-infrastructure/rep/pull/104/files, I think every robot_startup should set robot/name
, not set by each app_manager.
this PR is for launching multiple app_managers under one ROS core. |
I see, how about using remapping ?
|
it works with following command. rosrun app_manager app_manager _/robot/name:=hoge However when we use <node pkg="app_manager" type="app_manager" name="$(arg manager_node_name)"
args="$(arg applist_args)"
output="screen" respawn="$(arg respawn)">
<param name="/robot/name" value="$(arg robot_name)" if="$(arg use_robot_name)" />
<param name="/robot/type" value="$(arg robot_type)" if="$(arg use_robot_type)" />
<rosparam subst_value="true">
interface_master: http://$(arg master_address):$(arg master_port)
enable_app_replacement: $(arg enable_app_replacement)
enable_topic_remapping: $(arg enable_topic_remapping)
sigint_timeout: $(arg sigint_timeout)
sigterm_timeout: $(arg sigterm_timeout)
</rosparam>
</node> We all cannot use <node pkg="app_manager" type="app_manager" name="$(arg manager_node_name)"
args="$(arg applist_args)"
output="screen" respawn="$(arg respawn)">
<remap from="/robot/name" to="$(arg robot_name)" if="$(arg use_robot_name)" />
<remap from="/robot/type" to="$(arg robot_type)" if="$(arg use_robot_type)" />
<rosparam subst_value="true">
interface_master: http://$(arg master_address):$(arg master_port)
enable_app_replacement: $(arg enable_app_replacement)
enable_topic_remapping: $(arg enable_topic_remapping)
sigint_timeout: $(arg sigint_timeout)
sigterm_timeout: $(arg sigterm_timeout)
</rosparam>
</node> |
add robot name and type args in app_manager.launch
add node_name args in app_manager.launch