Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-documentation #293

Merged
merged 8 commits into from
Jan 27, 2025
Merged

update-documentation #293

merged 8 commits into from
Jan 27, 2025

Conversation

ymahlich
Copy link
Collaborator

This is an update to the documentation.
It contains updates to:

  • usage.md
  • README.md

@ymahlich ymahlich linked an issue Jan 14, 2025 that may be closed by this pull request
@ymahlich
Copy link
Collaborator Author

currently it only covers usage.md
We also need to take a look at the style.css, since it seems to be incompatible with the markdown engine jekyll / github recommends and the rendering of the codeblocks is off

@jjacobson95
Copy link
Collaborator

I'd recommend saving some time and using the previously defined work-around way that the code blocks were previously displayed (below) as jekyll really struggles with the built-in code block methods. But if you've already made progress getting jekyll to work with the standard code blocks, great!

work-around example:

<div class="code-box">
    <p>import coderdata as cd</p>
    <p><span class="code-comment"># Download a specific dataset</span></p>
    <p>cd.download_data_by_prefix('beataml')</p>
    <p><span class="code-comment"># Download all datasets</span></p>
    <p>cd.download_data_by_prefix()</p>
</div>

@ymahlich
Copy link
Collaborator Author

I am assuming that this is a "problem" of the styles.css, but I am not a webdev so I am unsure. What I can tell you is that the git-hub action to build the docs from this branch fails because the changes can't be deployed due to the repo settings. I am able to download the build artifacts though that contain the build html sites. Opening those build sites locally I can tell that the markdown renderer engine recognizes the codeblocks correctly (I think) but the styling creates some wonky results (see attached screen shot)

Screenshot 2025-01-14 at 10 44 17 AM

@jjacobson95
Copy link
Collaborator

This branch now has write permissions to the docs. The most recent one has been re-run and pushed so you can see changes there directly

@jjacobson95
Copy link
Collaborator

Feel free to update on the css but I remember there being some previous challenges in modifying the code block style hence the workaround.

@ymahlich ymahlich marked this pull request as ready for review January 27, 2025 17:27
@ymahlich ymahlich merged commit 5675103 into main Jan 27, 2025
2 checks passed
@ymahlich ymahlich deleted the 291-update-documentation branch January 27, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update documentation
2 participants