Skip to content

Commit

Permalink
new submission for correcting noLD failure on CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
jchiquet committed Jun 29, 2023
1 parent 1aae03a commit 409b65a
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: PLNmodels
Title: Poisson Lognormal Models
Version: 1.0.2
Version: 1.0.3
Authors@R: c(
person("Julien", "Chiquet", role = c("aut", "cre"), email = "[email protected]",
comment = c(ORCID = "0000-0002-3629-3429")),
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@

# PLNmodels 1.0.3

* higher tolerance on a single test (among 700) that fails on the 'noLD'
additional architecture on CRAN (tests without long double)

# PLNmodels 1.0.2 (2023-06-21)

* changed initial value in optim for variational variance (1 -> 0.1),
Expand Down
9 changes: 3 additions & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@

Submitting PLNmodels version 1.0.2 to CRAN
Submitting PLNmodels version 1.0.3 to CRAN

* changed initial value in optim for variational variance (1 -> 0.1),
which caused failure in some cases
* fix bug when using inception in PLNnetwork()
* starting handling of missing data
* slightly faster (factorized) initialization for PCA
Higher tolerance on a single test (among 700) that fails on the 'noLD' additional
architecture on CRAN (tests without long double)

## Tested environments

Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-plnmixture.R
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ test_that("Check that PLNmixture is running and robust (spherical variant)", {

expect_error(PLNmixture(Abundance ~ 0, weights = rep(1.0, nrow(trichoptera)), data = trichoptera))

expect_equal(sum(map_dbl(mix_wt$models, "loglik")), sum(map_dbl(mix_wo$models, "loglik")))
expect_equal(sum(map_dbl(mix_wt$models, "loglik")), sum(map_dbl(mix_wo$models, "loglik")), tolerance = 1e-1)

})

Expand Down

0 comments on commit 409b65a

Please sign in to comment.