feat: Add TO_<CHAR,STRING> functions
#1355
Conversation
This commit introduces the `TO_CHAR`, `TO_WCHAR`, `TO_STRING` and `TO_WSTRING` functions, all making use of already existing `X_TO_Y` functions.
| @@ -701,12 +702,10 @@ impl AnnotationMapImpl { | |||
|
|
|||
| /// annotates the given statement (using it's `get_id()`) with the given type-name | |||
| pub fn annotate(&mut self, s: &AstNode, annotation: StatementAnnotation) { | |||
| log::trace!("Annotation: {annotation:?} @ {s:?}"); | |||
There was a problem hiding this comment.
fyi I've previously introduced these trace statements but in hindsight I have to admit they're not as useful as I imagined (i.e. they're waaaaay too bloaty). A better approach would be a more concise representation but that's something I'll address (or not, who knows) when I have the pleasure to debug resolver bugs again :^)
| END_FUNCTION | ||
|
|
||
| FUNCTION TO_CHAR__STRING : CHAR | ||
| VAR_INPUT {ref} |
There was a problem hiding this comment.
The {ref} here is no longer necessary, since aggregate-type arguments are now always passed as pointers. Not blocking, we should probably change these for all occurances in the `stdlib
There was a problem hiding this comment.
Lets address this in another PR since I also forgot to remove the code-gen python scripts.
|
|
||
| // ----------------------------------------------------------------------------------------------------------- | ||
|
|
||
| FUNCTION TO_WCHAR<T: ANY> : WCHAR |
There was a problem hiding this comment.
Would it make sense here to constrict the generic type nature to ANY_INT?
This commit introduces the
TO_CHAR,TO_WCHAR,TO_STRINGandTO_WSTRINGfunctions, all making use of already existingX_TO_Yfunctions.EDIT: There's some issue with printf() statements giving incorrect validation errors, which needs to be fixed before this can be merged.