Revert "ci: Remove --depth=1000 in doing Flutter clone, to be added b…

…ack later" This reverts commit 2b99578. Fixes: zulip#1204 Signed-off-by: Zixuan James Li <[email protected]>
PIG208 · Jan 27, 2025 · 7b25db0 · 7b25db0
1 parent 4e85445
commit 7b25db0
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,9 +18,12 @@ jobs:
         distribution: temurin
 
     - name: Clone Flutter SDK
-      # TODO(#1204) reinstate shallow clone with --depth=1000 and its corresponding comment here
+      # We can't do a depth-1 clone, because we need the most recent tag
+      # so that Flutter knows its version and sees the constraint in our
+      # pubspec is satisfied.  It's uncommon for flutter/flutter to go
+      # more than 100 commits between tags.  Fetch 1000 for good measure.
       run: |
-        git clone -b main https://github.com/flutter/flutter ~/flutter
+        git clone --depth=1000 -b main https://github.com/flutter/flutter ~/flutter
         TZ=UTC git --git-dir ~/flutter/.git log -1 --format='%h | %ci | %s' --date=iso8601-local
         echo ~/flutter/bin >> "$GITHUB_PATH"