Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports animated gif with Imagick/Gmagick drivers #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aVadim483
Copy link

No description provided.

@dracony
Copy link
Member

dracony commented Mar 2, 2015

Thanks a lot!
Can you also add tests for the features you added ?
Otherwise it will have to wait until I have a bit more time to write the tests myself ( I promised people I would never merge untested code )

@aVadim483
Copy link
Author

I think you need just to add .gif picture in the current test. And it must be your brand picture - the fairy, but animated :)

@aVadim483
Copy link
Author

I didn't add new methods, I have refactored code in exiting methods. Of course, animated gifs works only with Imagick/Gmagick, under GD it works as static image with single frame.

@dracony
Copy link
Member

dracony commented Mar 2, 2015

In this case being able to handle animate gifs is the added functionality.

I imagine the test would try and perform these operations on an animated gif, make sure the changes are applied and that the gif stays animated after its saved.

Having these tests will make sure that in the future someone is not going to break your gif support by accident

@dracony
Copy link
Member

dracony commented Mar 2, 2015

Would it also work for the GMagick driver ? Since it's almost 100% same as Imagick one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants