Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mitoteam/jpgraph #4298

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Upgrade mitoteam/jpgraph #4298

merged 1 commit into from
Jan 2, 2025

Conversation

oleibman
Copy link
Collaborator

@oleibman oleibman commented Jan 2, 2025

They have made a change at our request to help us eliminate runInSeparateProcess for one or more tests. This will be helpful when we get to PhpUnit 11 (not imminent, since it doesn't support Php8.1, but it will happen eventually).

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • upgrade required software

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

They have made a change at our request to help us eliminate runInSeparateProcess for one or more tests. This will be helpful when we get to PhpUnit 11 (not imminent, since it doesn't support Php8.1, but it will happen eventually).
@oleibman oleibman added this pull request to the merge queue Jan 2, 2025
Merged via the queue into PHPOffice:master with commit 483fd49 Jan 2, 2025
13 of 14 checks passed
@oleibman oleibman deleted the mitoupgrade branch January 2, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant